Small speedup for dataclass __eq__ and __repr__#104904
Merged
ericvsmith merged 4 commits intopython:mainfrom May 30, 2023
Merged
Small speedup for dataclass __eq__ and __repr__#104904ericvsmith merged 4 commits intopython:mainfrom
ericvsmith merged 4 commits intopython:mainfrom
Conversation
Member
|
Those look great, @rhettinger! Thanks. I'll do a detailed code review then commit it. |
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 30, 2023
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110) pythongh-105071: add missing versionadded directive (python#105097) pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904) pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093) pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
Contributor
|
I belive I found a regression: #116647 |
This was referenced Jun 17, 2024
Member
|
Or you found that this resulted in a perhaps inadvertent bugfix ;-). Depends on Eric's intention for NANs in dataclasses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__eq__do a series ofandcomparisons rather than building a tuple and relying ontuple.__eq__.__repr__put the type name in the f-string rather than calling string concatenation explicitly.Old code:
New code:
Timings for a dataclass with two integer fields: