CI: Temporarily skip paths with spaces to avoid error#105110
Merged
hugovk merged 3 commits intopython:mainfrom May 30, 2023
Merged
CI: Temporarily skip paths with spaces to avoid error#105110hugovk merged 3 commits intopython:mainfrom
hugovk merged 3 commits intopython:mainfrom
Conversation
…iles includes a space"
Member
Author
|
✅ No error with a dummy file at https://github.com/python/cpython/actions/runs/5125091879/jobs/9217804839 |
carljm
approved these changes
May 30, 2023
gpshead
approved these changes
May 30, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 30, 2023
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110) pythongh-105071: add missing versionadded directive (python#105097) pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904) pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093) pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
Member
Maybe you should report the bug there? |
Member
Author
|
It's a feature: https://github.com/Ana06/get-changed-files#usage says the default behaviour is to return files separated by spaces ( (Let's continue discussion in #103914). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs like these:
Have
NEWSfiles in subdirectories containing spaces:Misc/NEWS.d/next/C API/2023-05-30-10-15-13.gh-issue-105071.dPtp7c.rstMisc/NEWS.d/next/C API/2023-05-30-19-11-09.gh-issue-105107.YQwMnm.rstBut the https://github.com/Ana06/get-changed-files action (added in #103914) fails for such files with:
We ran into this before and worked around it in #103019 by skipping
Miscand its subdirs.Let's do something similar here, by replacing
Miscwith a list of its subdirs that are absent a space.See also python/core-workflow#186 to rename the
C APIandCore and Builtinsdirectories toC-APIandCore-and-Builtinsto avoid this altogether.