[APP-397] feat: unify watch clients#8519
Conversation
|
Nice work on this! The unified SSE endpoint is a solid approach for the connection limit issue, and the code is well-documented. One area to flag: the Design consideration:
The params approach works, but it makes the class fairly modal. It is worth considering whether the connection management logic (heartbeat, auto-close, reconnect) should live in a wrapper instead, keeping Minor items:
Happy to chat through any of this! Developed in collaboration with Claude Code |
|
@ericpgreen2 Reworked as a wrapper. |
Looks good! Let me know when ready for final review. |
Builds on #8504 and #8026 to unify the
WatchFilesClient,WatchResourcesClientandWatchRequestClientinto a singleFileAndResourceWatcher.SSEFetchClientChecklist: