Skip to content

Improve headers linking - #43747

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-css
Aug 11, 2017
Merged

Improve headers linking#43747
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-css

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

A little file to run this new rustdoc upon:

use std::ops::Deref;

/// fooo
pub struct Foo {
    /// lol
    pub x: u32,
    /// yeay
    pub y: i32,
}

impl Deref for Foo {
    type Target = u32;

    fn deref(&self) -> &u32 {
        &self.x
    }
}

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

Built this locally so i could get my own rendering. Looks good! For posterity: Basically this gives certain major headers their own section marker that appears at the end, rather than automatically tagging it onto each link inside the header. This keeps "Methods from Deref" from generating a lot of spurious section markers.

r=me pending travis

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Aug 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 8ac4336 has been approved by QuietMisdreavus

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 10, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 11, 2017
bors added a commit that referenced this pull request Aug 11, 2017
MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
@bors
bors merged commit 8ac4336 into rust-lang:master Aug 11, 2017
@GuillaumeGomez
GuillaumeGomez deleted the fix-css branch August 11, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants