Improve enum variants display - #43795
Merged
Merged
Conversation
Contributor
|
r=me pending travis (i really doubt it affects anything that travis will catch, but this is my protocol |
Member
Author
|
With 5px:
|
GuillaumeGomez
force-pushed
the
improve-variants-doc-style
branch
from
August 10, 2017 22:34
87cd3e7 to
b617200
Compare
Contributor
|
(This is about a discussion i brought up in IRC - making it 5px matches the rule underneath it and makes it line up better) Yes, i like this more - r=me pending travis, again |
Member
Author
|
@bors: r=QuietMisdreavus rollup |
Collaborator
|
📌 Commit b617200 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 11, 2017
…-style, r=QuietMisdreavus Improve enum variants display r? @rust-lang/docs Before: <img width="1440" alt="screen shot 2017-08-11 at 00 22 54" src="https://user-images.githubusercontent.com/3050060/29194776-728ce0e2-7e2b-11e7-8299-8300cc0c168b.png"> After: <img width="1440" alt="screen shot 2017-08-11 at 00 22 57" src="https://user-images.githubusercontent.com/3050060/29194783-78867558-7e2b-11e7-9226-1327fd20163a.png"> (The doc of the variant is more aligned with the "[-]" now).
bors
added a commit
that referenced
this pull request
Aug 11, 2017
MaloJaffre
added a commit
to MaloJaffre/rust
that referenced
this pull request
Aug 11, 2017
…-style, r=QuietMisdreavus Improve enum variants display r? @rust-lang/docs Before: <img width="1440" alt="screen shot 2017-08-11 at 00 22 54" src="https://user-images.githubusercontent.com/3050060/29194776-728ce0e2-7e2b-11e7-8299-8300cc0c168b.png"> After: <img width="1440" alt="screen shot 2017-08-11 at 00 22 57" src="https://user-images.githubusercontent.com/3050060/29194783-78867558-7e2b-11e7-9226-1327fd20163a.png"> (The doc of the variant is more aligned with the "[-]" now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @rust-lang/docs
Before:
After:
(The doc of the variant is more aligned with the "[-]" now).