Add --all flag to cron event delete#98
Merged
danielbachhuber merged 12 commits intowp-cli:mainfrom Feb 13, 2024
Merged
Conversation
janw-me
approved these changes
Jun 8, 2023
schlessera
reviewed
Jun 8, 2023
schlessera
previously requested changes
Jun 8, 2023
…-command into add-all-flag-to-delete
Member
|
I took another look at the out of sync files and corrected them. @schlessera can you confirm your review conflicts are now resolved? |
36 tasks
danielbachhuber
approved these changes
Feb 13, 2024
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @Mike-Hermans !
Changes have been addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #81
Fixes #39 by making the command more consistent with the
wp cron event runcommand.It is now possible to delete multiple cron events at once by either:
Since the selection process of the
runanddeletecommand is now the same, a separate function has been added to filter the required hooks (::get_selected_cron_events()).This function now also includes support for the
--excludeparameter added in #97.