Skip to content

feat: Merge nacos-plugin PostgreSQL & Base Implementation#14041

Merged
KomachiSion merged 26 commits into
alibaba:developfrom
WangzJi:feature/unified-datasource-dialect
Dec 19, 2025
Merged

feat: Merge nacos-plugin PostgreSQL & Base Implementation#14041
KomachiSion merged 26 commits into
alibaba:developfrom
WangzJi:feature/unified-datasource-dialect

Conversation

@WangzJi

@WangzJi WangzJi commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

This PR merges the PostgreSQL and Base datasource implementations from the nacos-plugin repository into the main
nacos repository. It also restores ConfigInfoAggrMapper and ConfigInfoAggrMapperByMySql which were previously deleted but are required dependencies for the merged code.

Brief changelog

  1. Merge from nacos-plugin:
  • Added postgresql dialect and mapper implementations.
  • Added base mapper implementations to support the plugin architecture.
  • Added DatabaseDialect interface and DatabaseDialectManager.
  1. Restore Deleted Dependencies:
    Restored plugin/datasource/src/main/java/com/alibaba/nacos/plugin/datasource/mapper/ConfigInfoAggrMapper.java from git history.
    Restored plugin/datasource/src/main/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoAggrMapperByMySql.java from git history.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

wuchubuzai2018 and others added 24 commits November 8, 2022 14:37
* [ISSUES alibaba#17] add oracle datasource plugin

* [ISSUES alibaba#17] add test query comment
* 添加damang插件

* dameng适配mysql的分页

* 添加文档以及注意事项

* 修改错误文字

* 添加表结构相关注意事项

* 添加错误码映射关系

* 适配2.3.0

* 删除脏的语句

* 添加注释

* 添加注释

---------

Co-authored-by: asdc <asdc>
* 添加 Microsoft SQL Server 支持

* 修正错误:意外的虚类的声明

* 修正错误:意外的继承错误与冗余代码的清理
- 实现兼容OpenGauss功能,整理Mapper结果,不在继承Mysql
- 添加 GaussDB 函数枚举类
- 创建 OpenGauss 兼容 MySQL 的数据库模式
- 在数据库类型常量中添加 GaussDB
升级nacos版本2.3.0-SNAPSHOT ==> 2.4.2

Co-authored-by: 杨翊 SionYang <xiweng.yy@alibaba-inc.com>
升级nacos版本2.3.0-SNAPSHOT ==> 2.4.2

Co-authored-by: 杨翊 SionYang <xiweng.yy@alibaba-inc.com>
…urrent time function. (alibaba#63)

Override getFunction method. Implement a function to get the current time dynamically from different databases

Closes alibaba#12786
…urrent time function. (alibaba#63)

Override getFunction method. Implement a function to get the current time dynamically from different databases

Closes alibaba#12786
* feat: add yashan datasource plugin implementation

* fix: Rename the database

* fix: Rename the database2
…nd complete PostgreSQL migration

1. Implement `MySqlDatabaseDialect` and `DerbyDatabaseDialect` to unify pagination logic across datasources.
2. Register `DatabaseDialect` SPI for MySQL, Derby, and PostgreSQL.
3. Register PostgreSQL Mappers in `Mapper` SPI.
4. Add `DatabaseTypeConstant.DERBY` and `TrustedDerbyFunctionEnum` to support Derby dialect.
5. Finalize integration of PostgreSQL plugin (migrated from nacos-plugin).
- Restore ConfigInfoAggrMapperByMySql.java from git history
- Restore ConfigInfoAggrMapper.java from git history
- These files are required dependencies for nacos-plugin BaseConfigInfoAggrMapper but were previously deleted from nacos core
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@CLAassistant

CLAassistant commented Dec 18, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 11 committers have signed the CLA.

✅ wuchubuzai2018
✅ uselessbaozi
✅ onewe
✅ KomachiSion
✅ WangzJi
✅ caoyanan666
✅ silent-night-no-trace
❌ xiaoyonghaoe
❌ SweetWuXiaoMei
❌ henglianghu
❌ muzhi9018
You have signed the CLA already but the status is still pending? Let us recheck it.

@wuyfee

wuyfee commented Dec 19, 2025

Copy link
Copy Markdown

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
❌ - deploy (standalone & cluster & standalone_auth): failure
❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped
❌ - e2e-go-test (standalone & cluster): skipped
❌ - e2e-cpp-test (standalone & cluster): skipped
❌ - e2e-csharp-test (standalone & cluster): skipped
❌ - e2e-nodejs-test (standalone & cluster): skipped
❌ - e2e-python-test (standalone & cluster): skipped
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion
KomachiSion merged commit 0e30f41 into alibaba:develop Dec 19, 2025
2 of 3 checks passed
@wuyfee

wuyfee commented Dec 19, 2025

Copy link
Copy Markdown

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
❌ - deploy (standalone & cluster & standalone_auth): failure
❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped
❌ - e2e-go-test (standalone & cluster): skipped
❌ - e2e-cpp-test (standalone & cluster): skipped
❌ - e2e-csharp-test (standalone & cluster): skipped
❌ - e2e-nodejs-test (standalone & cluster): skipped
❌ - e2e-python-test (standalone & cluster): skipped
✅ - clean (standalone & cluster & standalone_auth): success

GoldenSupremeSaltedFish pushed a commit to GoldenSupremeSaltedFish/nacos that referenced this pull request Jan 30, 2026
…rce-dialect

feat: Merge nacos-plugin PostgreSQL & Base Implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Mature Plugins from nacos-group/nacos-plugin to Main Repository