Skip to content

[ISSUE #15171] Remove startup bash re-exec logic#15188

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
jay666mnj:revert-startup-bash-reexec
May 20, 2026
Merged

[ISSUE #15171] Remove startup bash re-exec logic#15188
KomachiSion merged 1 commit into
alibaba:developfrom
jay666mnj:revert-startup-bash-reexec

Conversation

@jay666mnj

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Remove the bash re-exec logic introduced by #15177 now that startup.sh has been made sh-compatible by #15178.

This PR also updates startup-native.sh to use POSIX-compatible conditionals, so it no longer needs the bash re-exec guard.

Brief changelog

  • Remove bash re-exec guard from startup.sh
  • Remove bash re-exec guard from startup-native.sh
  • Replace remaining bash-only [[ ... ]] conditionals in startup-native.sh with POSIX-compatible [ ... ]

Verifying this change

  • Select-String -Path distribution\bin\startup.sh,distribution\bin\startup-native.sh -Pattern "BASH_VERSION|exec bash|Re-execute|re-exec"
  • rg -n "\[\[|\]\]|&>|read -p" distribution\bin\startup.sh distribution\bin\startup-native.sh
  • git diff --check

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [√] Make sure there is a Github issue filed for the change.
  • [√] Format the pull request title like [ISSUE #123] ....
  • [√] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction.
  • Run mvn -B clean package apache-rat:check spotbugs:check -DskipTests.

@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion merged commit 209376b into alibaba:develop May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] startup.sh fails on Ubuntu due to dash incompatibility with [[ syntax

3 participants