This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Use deque instead of list for FIFO queue in Linux Socket buffer#1453
Merged
Conversation
ekilmer
added a commit
that referenced
this pull request
Jul 11, 2019
* master: Fix FileNotFoundError when loading existing state (#1480) Add undoc-members to api docs (#1478) Improve deprecation warnings (#1476) Fix sycall getdents (#1472) Dev apidocs refactor (#1469) Enforce black formatting (#1466) Moving issymbolic to smtlib (#1456) Revert Unicorn Dependency Update (#1459) Manticore 0.3.0 (#1448) Install native deps on rtd (#1457) Fix check for symbolic syscall argument (#1452) Use deque instead of list for FIFO queue in Linux Socket buffer (#1453)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More efficient to use deque for FIFO buffer of Socket data. O(1) for
popleft()instead of O(n) forinsert(0, c)https://docs.python.org/3/library/collections.html#collections.dequeThis change is