Skip to content
This repository was archived by the owner on Jun 24, 2026. It is now read-only.

Enforce black formatting#1466

Merged
ehennenfent merged 2 commits into
masterfrom
dev-black-formatting
Jun 18, 2019
Merged

Enforce black formatting#1466
ehennenfent merged 2 commits into
masterfrom
dev-black-formatting

Conversation

@Tiecoon

@Tiecoon Tiecoon commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

create a pyproject.toml so users don't have to worry about command line flags for black


This change is Reviewable

@CLAassistant

CLAassistant commented Jun 12, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ekilmer

ekilmer commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

Would be nice to propagate this to .travis.yml also. Should appear on line 43

@Tiecoon
Tiecoon requested review from ehennenfent and removed request for ehennenfent June 12, 2019 20:15
@ehennenfent

Copy link
Copy Markdown
Contributor

@Tiecoon Just to make sure having a pyproject.toml in the root doesn't break the install process, can you run pip install . in a fresh virtual environment and make sure it works okay?

@Tiecoon

Tiecoon commented Jun 12, 2019

Copy link
Copy Markdown
Contributor Author

it works fine here, unicorn still complains if i just pip install .[native], but it does that on master for me as well currently.

@Tiecoon

Tiecoon commented Jun 12, 2019

Copy link
Copy Markdown
Contributor Author

i can figure out how to specify a build system in the pyproject.toml.

https://pip.pypa.io/en/stable/reference/pip/#build-system-interface

but it should still follow " The current interface to the build system is via the setup.py command line script - all build actions are defined in terms of the specific setup.py command line that will be run to invoke the required action." anyways

@ehennenfent ehennenfent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ehennenfent
ehennenfent merged commit 94c2f21 into master Jun 18, 2019
@ehennenfent
ehennenfent deleted the dev-black-formatting branch June 18, 2019 21:57
ekilmer added a commit that referenced this pull request Jul 11, 2019
* master:
  Fix FileNotFoundError when loading existing state (#1480)
  Add undoc-members to api docs (#1478)
  Improve deprecation warnings (#1476)
  Fix sycall getdents (#1472)
  Dev apidocs refactor (#1469)
  Enforce black formatting (#1466)
  Moving issymbolic to smtlib (#1456)
  Revert Unicorn Dependency Update (#1459)
  Manticore 0.3.0 (#1448)
  Install native deps on rtd (#1457)
  Fix check for symbolic syscall argument (#1452)
  Use deque instead of list for FIFO queue in Linux Socket buffer (#1453)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants