This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Experimental coverage changes#1705
Merged
Merged
Conversation
added 7 commits
May 12, 2020 14:07
Tells coverage.py to record coverage for individual test cases, and makes CodeCov tolerate a small drop in overall coverage percentage to account for nondeterministic gas tests.
Appears to break use of subprocess in integration tests
ehennenfent
marked this pull request as ready for review
May 15, 2020 23:21
bradlarsen
approved these changes
May 19, 2020
bradlarsen
left a comment
bradlarsen
left a comment
There was a problem hiding this comment.
If the COVERAGE_RCFILE variable isn't actually needed, let's get rid of that. (If it is needed, that's fine.)
LGTM! Thanks!
ekilmer
added a commit
that referenced
this pull request
Jun 15, 2020
* master: Symbolic model for strcpy (#1681) Rollback to support yices again (#1714) Fix default output space when workspace is in mem: (#1724) VMTests tests for istanbul (#1676) Snapshots & is_main (#1710) Fix Black (#1718) Use CoverageRC, Make CodeCov Less Aggressive (#1705) Fix plugin enable/disable magic (#1708) Add a warning when selected no methods for inclusion (#1707) Remove duplicated entries (#1709) Blacken (#1711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tells coverage.py to respect the top-level coveragerc file, and makes CodeCov tolerate a small drop in overall coverage percentage to account for nondeterministic gas tests.