This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Add a warning when selected no methods for inclusion#1707
Merged
Conversation
ehennenfent
reviewed
May 15, 2020
| logger.warning("No functions selected, adding False to path constraint.") | ||
| # constrain the input so it can take only the interesting values | ||
| constraint = reduce(Operators.OR, (tx.data[:4] == x for x in selected_functions)) | ||
| constraint = reduce(Operators.OR, (tx.data[:4] == x for x in selected_functions), False) |
Contributor
There was a problem hiding this comment.
This unconditionally adds False to the path constraint, right? Not just if there aren't any functions selected, as the log message would seem to imply. Is the problem that constraint is empty otherwise?
Contributor
There was a problem hiding this comment.
Per dev meeting, False is needed here so that the reduce isn't empty when selected_functions is empty.
ehennenfent
approved these changes
May 19, 2020
ehennenfent
left a comment
ehennenfent
left a comment
Contributor
There was a problem hiding this comment.
Clarification questions answered; LGTM!
| logger.warning("No functions selected, adding False to path constraint.") | ||
| # constrain the input so it can take only the interesting values | ||
| constraint = reduce(Operators.OR, (tx.data[:4] == x for x in selected_functions)) | ||
| constraint = reduce(Operators.OR, (tx.data[:4] == x for x in selected_functions), False) |
Contributor
There was a problem hiding this comment.
Per dev meeting, False is needed here so that the reduce isn't empty when selected_functions is empty.
ekilmer
added a commit
that referenced
this pull request
Jun 15, 2020
* master: Symbolic model for strcpy (#1681) Rollback to support yices again (#1714) Fix default output space when workspace is in mem: (#1724) VMTests tests for istanbul (#1676) Snapshots & is_main (#1710) Fix Black (#1718) Use CoverageRC, Make CodeCov Less Aggressive (#1705) Fix plugin enable/disable magic (#1708) Add a warning when selected no methods for inclusion (#1707) Remove duplicated entries (#1709) Blacken (#1711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.