This repository was archived by the owner on Jun 24, 2026. It is now read-only.
New working model of strlen#1725
Merged
Merged
Conversation
sschriner
marked this pull request as ready for review
June 17, 2020 14:48
ekilmer
approved these changes
Jun 18, 2020
ekilmer
left a comment
ekilmer
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the fix!
9 tasks
Closed
ehennenfent
reviewed
Jun 23, 2020
ehennenfent
left a comment
ehennenfent
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Your implementation looks solid to me, but I did leave a couple of questions about why you chose this particular approach.
sschriner
commented
Jun 30, 2020
Contributor
Author
|
@ekilmer @ehennenfent I opted to preserve both model strategies and note the difference in them. I'm thinking this is probably the best solution for allowing the most user control over strategies and tradeoffs based on the program being analyzed. |
ekilmer
added a commit
that referenced
this pull request
Jul 17, 2020
* master: Create a model for strncpy (#1770) Add doc, fix output bugs (#1769) Update EVM usage example (#1772) New working model of strlen (#1725) Typo (#1768) Specialized iterative serialization for Array (#1756) Enable nightly uploads to PyPI (#1757) Manticore 0.3.4 (#1720) Manticore verifier (#1717) Nightly MacOS Tests (#1614) Remove/procrastinate solver query in ether leak detector (#1727) Fix constant folding & constraint set slicing (#1706)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the strlen model based on work from strcpy. It seems to be working on concrete and symbolic values. The symbolic testing for strlen will need to be updated.