This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Add doc, fix output bugs#1769
Merged
Merged
Conversation
feliam
commented
Jul 6, 2020
| :maxdepth: 2 | ||
| :caption: Contents: | ||
|
|
||
| verifier |
Contributor
Author
There was a problem hiding this comment.
This may need to be CLI-tools
And then inside that we should have manpage-like documentation on how to use the commandline tools for each tool. (So far we have plain manticore and manticore-verifier )
ehennenfent
suggested changes
Jul 6, 2020
ehennenfent
left a comment
ehennenfent
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! I suggested a few spelling fixes, but overall the docs looks like a pretty comprehensive introduction to the verifier. If we intend for this to be used externally, I think it'd also be worth adding a section to the README with a sentence or two about manticore-verifier and a link to the documentation on RTD.
Co-authored-by: Eric Hennenfent <eric.hennenfent@trailofbits.com>
ehennenfent
approved these changes
Jul 9, 2020
ehennenfent
left a comment
ehennenfent
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for adding the README link.
ekilmer
added a commit
that referenced
this pull request
Jul 17, 2020
* master: Create a model for strncpy (#1770) Add doc, fix output bugs (#1769) Update EVM usage example (#1772) New working model of strlen (#1725) Typo (#1768) Specialized iterative serialization for Array (#1756) Enable nightly uploads to PyPI (#1757) Manticore 0.3.4 (#1720) Manticore verifier (#1717) Nightly MacOS Tests (#1614) Remove/procrastinate solver query in ether leak detector (#1727) Fix constant folding & constraint set slicing (#1706)
ekilmer
added a commit
that referenced
this pull request
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readme updated to link to manticore-verifier documentation
Typos and output cleanups