Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

Migrate from requests to axios#146

Merged
leerob merged 1 commit into
masterfrom
pr/drop-requests
Mar 31, 2021
Merged

Migrate from requests to axios#146
leerob merged 1 commit into
masterfrom
pr/drop-requests

Conversation

@jesec

@jesec jesec commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Per suggestion of #144 (review).

@jesec
jesec requested review from leerob and robertsLando March 31, 2021 14:57
Comment thread lib/requests.ts
Comment thread lib/index.ts

@robertsLando robertsLando left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando

robertsLando commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

@leerob @jesec If it's not clear I'm ok to release a 3.0.0 but I think we firstly need to end this: #135

After that is merged we should bump the version, create a release on github start building the binaries and then once done publish it to npm and bump it in pkg too

@jesec

jesec commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

I don't think we should release before we got the binaries ready. But we can bump the version.

@robertsLando

Copy link
Copy Markdown
Contributor

Yeah maybe I explained wrongly I don't want to release it now, I have updated my comment

@jesec

jesec commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

I can take over the workflow branch, if you don't mind. To start building binaries, we have to be able to pull RHEL tools, per discussions in #124. I have sent necessary info to @leerob .

Additionally, we have to add cross-compiling support (fix Error! Not able to build for 'arm64' here, only for 'x64'). Github Actions don't have arm64 host and emulation is soooo slow.

@robertsLando

Copy link
Copy Markdown
Contributor

What about using travis for arm64?

@robertsLando

Copy link
Copy Markdown
Contributor

I can take over the workflow branch, if you don't mind

Sure no problem!

@leerob

leerob commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Yes, I will cut a release after we get CI working 👍

@leerob
leerob merged commit 5215179 into master Mar 31, 2021
@leerob
leerob deleted the pr/drop-requests branch March 31, 2021 15:57
@jesec

jesec commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

Thanks.

I like Github Actions more. I think it could be beneficial to have support for cross-compiling in this project, as well. But yeah, if we do need native, we can use Travis or Azure.

@robertsLando

Copy link
Copy Markdown
Contributor

I like Github Actions more

Me too but AFAIK there is no arm64 suppport in available runners yet. We could ask @leerob if @vercel can provide us a custom arm64 runner for this purpose

@leerob

leerob commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Would like to stick with GitHub Actions if at all possible. Could we enumerate the pros/cons in the CI PR?

@leerob

leerob commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

If it's possible to get a custom arm runner, let me know and send some docs and I can ask!

@robertsLando

Copy link
Copy Markdown
Contributor

@leerob

leerob commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Let's start with getting GH Actions CI working and then I will explore this! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants