Add paginations to comments API #9407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jd/comments-e2e-scaffolding # Conflicts: # packages/common/src/services/remote-config/feature-flags.ts # packages/discovery-provider/src/tasks/entity_manager/entity_manager.py # packages/libs/src/sdk/api/generated/default/.openapi-generator/FILES # packages/libs/src/sdk/api/generated/default/models/index.ts
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/discovery-one.env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/discovery-one.env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | bae2493 | core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-three.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-three.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-three.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-three.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | bae2493 | core/infra/dev_config/content-three.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-two.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-two.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-two.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-two.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | bae2493 | core/infra/dev_config/content-two.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-one.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | 12bdddd | core/infra/dev_config/content-one.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-one.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | bdb7e40 | core/infra/dev_config/content-one.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | bae2493 | core/infra/dev_config/content-one.docker.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
isaacsolo
force-pushed
the
is-comment-paginations
branch
from
de2e750 to
bae2493
Compare
DejayJD
approved these changes
Aug 12, 2024
Contributor
DejayJD
left a comment
DejayJD
left a comment
There was a problem hiding this comment.
LGTM will test out whenever this makes it to staging 💯
schottra
added a commit
that referenced
this pull request
Aug 13, 2024
…ts-round-2 * origin/main: (43 commits) Testnet configuration for cometbft core (#9421) Fix pagination args (#9425) [QA-1501] Fix mobile search input (#9426) Add paginations to comments API (#9407) [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Audius Client (Web and Mobile) v1.5.94 check is_custom_musical_key before pulling in calculated key in repairer (#9417) Set is_custom_musical_key (#9418) add is_custom_musical_key (#9416) fix repairer eager loading (#9414) [PAY-3332] Remixers users endpoint (#9401) clean up aa endpts and limit ffprobe fields (#9413) relay retries (#9410) Audius Protocol v0.6.166 [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411) [QA-1491] Fix balance polling bug (#9402) Fix lint (#9412) [QA-1356] Improve notification UI (#9390) Fix useClickOutside (#9409) Add better error messages for Claimable Tokens Program (#9369) ...
audius-infra
pushed a commit
that referenced
this pull request
Aug 13, 2024
[06ee8a1] Fix pagination args (#9425) Isaac Solo [f7dad77] Add paginations to comments API (#9407) Isaac Solo [dd7b490] check is_custom_musical_key before pulling in calculated key in repairer (#9417) Michelle Brier [ee99fd4] add is_custom_musical_key (#9416) Michelle Brier [91d5c6f] fix repairer eager loading (#9414) Michelle Brier [f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed [cc77d13] clean up aa endpts and limit ffprobe fields (#9413) Michelle Brier [b7b8cd0] relay retries (#9410) alecsavvy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pagination args to comments API and add reaction counts. Just using sort by most recent for now.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Added integration tests for this.