relay retries #9410
relay retries #9410
Conversation
|
| return e instanceof Error ? e : new Error(String(e)) | ||
| } | ||
|
|
||
| export const retryPromise = async <T>(task: () => Promise<T>, retries = 128): Promise<T> => { |
There was a problem hiding this comment.
128 seems...a bit high? 😅
Especially if the timeout between is half a second. This is going to probably exceed the HTTP timeout from most clients.
I think 3 times is the standard for most of the client code.
There was a problem hiding this comment.
we use 128 for the confirmations as well but yeah, i can lower the intensity a bit
There was a problem hiding this comment.
we do want it longer than the container restarts which are something like 30s iirc
…ts-round-2 * origin/main: (43 commits) Testnet configuration for cometbft core (#9421) Fix pagination args (#9425) [QA-1501] Fix mobile search input (#9426) Add paginations to comments API (#9407) [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Audius Client (Web and Mobile) v1.5.94 check is_custom_musical_key before pulling in calculated key in repairer (#9417) Set is_custom_musical_key (#9418) add is_custom_musical_key (#9416) fix repairer eager loading (#9414) [PAY-3332] Remixers users endpoint (#9401) clean up aa endpts and limit ffprobe fields (#9413) relay retries (#9410) Audius Protocol v0.6.166 [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411) [QA-1491] Fix balance polling bug (#9402) Fix lint (#9412) [QA-1356] Improve notification UI (#9390) Fix useClickOutside (#9409) Add better error messages for Claimable Tokens Program (#9369) ...
[06ee8a1] Fix pagination args (#9425) Isaac Solo [f7dad77] Add paginations to comments API (#9407) Isaac Solo [dd7b490] check is_custom_musical_key before pulling in calculated key in repairer (#9417) Michelle Brier [ee99fd4] add is_custom_musical_key (#9416) Michelle Brier [91d5c6f] fix repairer eager loading (#9414) Michelle Brier [f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed [cc77d13] clean up aa endpts and limit ffprobe fields (#9413) Michelle Brier [b7b8cd0] relay retries (#9410) alecsavvy
2 participants
Description
Adds retry logic to some of relay's operations, not sure this will fix the specific issue with the fluctuating chain health but it'll help with chain restarts and connectivity errors.
How Has This Been Tested?
audius-cmd test