Skip to content

Conversation

@phelpsdb
Copy link
Contributor

Description

Allows stage nodes to run and peer correctly

How Has This Been Tested?

Ran successfully on stage dns 2, 3, and 5

@phelpsdb phelpsdb requested a review from alecsavvy August 12, 2024 17:33
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: a5634ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian
Copy link

gitguardian bot commented Aug 12, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/discovery-one.docker.env View secret
11648676 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/discovery-one.env View secret
11648678 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-three.env View secret
11648678 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-two.docker.env View secret
11648679 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-two.env View secret
11648680 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-one.env View secret
11648680 Triggered Generic High Entropy Secret a5634ca core/infra/dev_config/content-one.docker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/phelpsdb-core-stage-config

Comment on lines 39 to 57
"power": "25",
"name": "foundation-discovery-2"
},
{
"address": "2F13439B2EE4C34BAFE643F89575F40B7863A079",
"pub_key": {
"type": "tendermint/PubKeyEd25519",
"value": "Ubt7ViBm+mG24G+bbG8NgL7NMuwZ/u6uyf9taTwgsEI="
},
"power": "25",
"name": "foundation-discovery-3"
},
{
"address": "C9B1ED3D3040E0C2AC70E3215F0EA9B16B401BCA",
"pub_key": {
"type": "tendermint/PubKeyEd25519",
"value": "mj5kYzxWEG7iAnHAiJoUiJoPIOItBOEdr6W5sGTf0iY="
},
"power": "25",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind changing the power to 10? i used 25 for local dev so the four nodes all add up to 100 but stage / prod don't have those same numbers

@phelpsdb phelpsdb force-pushed the phelpsdb-core-stage-config branch 2 times, most recently from ab01620 to 94a2961 Compare August 12, 2024 21:06
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/phelpsdb-core-stage-config

@phelpsdb phelpsdb force-pushed the phelpsdb-core-stage-config branch from 94a2961 to accdf67 Compare August 12, 2024 21:22
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/phelpsdb-core-stage-config

@phelpsdb phelpsdb force-pushed the phelpsdb-core-stage-config branch from accdf67 to a5634ca Compare August 12, 2024 21:35
Copy link
Contributor

@alecsavvy alecsavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/phelpsdb-core-stage-config

@phelpsdb phelpsdb merged commit f88389d into main Aug 13, 2024
@phelpsdb phelpsdb deleted the phelpsdb-core-stage-config branch August 13, 2024 00:41
schottra added a commit that referenced this pull request Aug 13, 2024
…ts-round-2

* origin/main: (43 commits)
  Testnet configuration for cometbft core (#9421)
  Fix pagination args (#9425)
  [QA-1501] Fix mobile search input (#9426)
  Add paginations to comments API (#9407)
  [C-4932] Add CommentBody component to harmony and harmony-native (#9415)
  Audius Client (Web and Mobile) v1.5.94
  check is_custom_musical_key before pulling in calculated key in repairer (#9417)
  Set is_custom_musical_key (#9418)
  add is_custom_musical_key (#9416)
  fix repairer eager loading (#9414)
  [PAY-3332] Remixers users endpoint (#9401)
  clean up aa endpts and limit ffprobe fields (#9413)
  relay retries (#9410)
  Audius Protocol v0.6.166
  [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411)
  [QA-1491] Fix balance polling bug (#9402)
  Fix lint (#9412)
  [QA-1356] Improve notification UI (#9390)
  Fix useClickOutside (#9409)
  Add better error messages for Claimable Tokens Program (#9369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants