-
Notifications
You must be signed in to change notification settings - Fork 126
Testnet configuration for cometbft core #9421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/discovery-one.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-three.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-three.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-two.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-two.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-one.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | a5634ca | core/infra/dev_config/content-one.docker.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Preview this change https://demo.audius.co/phelpsdb-core-stage-config |
core/config/genesis/stage.json
Outdated
| "power": "25", | ||
| "name": "foundation-discovery-2" | ||
| }, | ||
| { | ||
| "address": "2F13439B2EE4C34BAFE643F89575F40B7863A079", | ||
| "pub_key": { | ||
| "type": "tendermint/PubKeyEd25519", | ||
| "value": "Ubt7ViBm+mG24G+bbG8NgL7NMuwZ/u6uyf9taTwgsEI=" | ||
| }, | ||
| "power": "25", | ||
| "name": "foundation-discovery-3" | ||
| }, | ||
| { | ||
| "address": "C9B1ED3D3040E0C2AC70E3215F0EA9B16B401BCA", | ||
| "pub_key": { | ||
| "type": "tendermint/PubKeyEd25519", | ||
| "value": "mj5kYzxWEG7iAnHAiJoUiJoPIOItBOEdr6W5sGTf0iY=" | ||
| }, | ||
| "power": "25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind changing the power to 10? i used 25 for local dev so the four nodes all add up to 100 but stage / prod don't have those same numbers
ab01620 to
94a2961
Compare
|
Preview this change https://demo.audius.co/phelpsdb-core-stage-config |
94a2961 to
accdf67
Compare
|
Preview this change https://demo.audius.co/phelpsdb-core-stage-config |
accdf67 to
a5634ca
Compare
alecsavvy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Preview this change https://demo.audius.co/phelpsdb-core-stage-config |
…ts-round-2 * origin/main: (43 commits) Testnet configuration for cometbft core (#9421) Fix pagination args (#9425) [QA-1501] Fix mobile search input (#9426) Add paginations to comments API (#9407) [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Audius Client (Web and Mobile) v1.5.94 check is_custom_musical_key before pulling in calculated key in repairer (#9417) Set is_custom_musical_key (#9418) add is_custom_musical_key (#9416) fix repairer eager loading (#9414) [PAY-3332] Remixers users endpoint (#9401) clean up aa endpts and limit ffprobe fields (#9413) relay retries (#9410) Audius Protocol v0.6.166 [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411) [QA-1491] Fix balance polling bug (#9402) Fix lint (#9412) [QA-1356] Improve notification UI (#9390) Fix useClickOutside (#9409) Add better error messages for Claimable Tokens Program (#9369) ...
Description
Allows stage nodes to run and peer correctly
How Has This Been Tested?
Ran successfully on stage dns 2, 3, and 5