[QA-1537] Remove unnecessary short circuit logic for gated tracks in get_remixes_of #9613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rickyrombo
approved these changes
Sep 3, 2024
audius-infra
pushed a commit
that referenced
this pull request
Sep 4, 2024
[6755daa] Pin Rust version for 'prod' DN dockerfile (#9607) Marcus Pasell [aa766ce] [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) Marcus Pasell [b904856] [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) Reed [0deaa00] Blast getMessages supports all audiences (#9618) Reed [62a4937] [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Reed [78033ae] Remove ToUserId in blast ws fan-out (#9615) Reed [661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn [3f325be] [QA-1537] Remove unnecessary short circuit logic for gated tracks in get_remixes_of (#9613) Randy Schott [e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic in
get_remixes_ofevolved over a few different tickets/features to a point where we are accidentally excluding remixes for all gated types that are not usdc purchases. The original intention of this line was to fix a bug around remixes for usdc purchases. So it now appears to be unnecessary.However, we do still hide remixes in the client. And that needs to be resolved separately.
How Has This Been Tested?
Local stack