[PAY-3389] Fix duplicate blast messages in 1:1 threads #9621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rickyrombo
approved these changes
Sep 3, 2024
audius-infra
pushed a commit
that referenced
this pull request
Sep 4, 2024
[6755daa] Pin Rust version for 'prod' DN dockerfile (#9607) Marcus Pasell [aa766ce] [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) Marcus Pasell [b904856] [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) Reed [0deaa00] Blast getMessages supports all audiences (#9618) Reed [62a4937] [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Reed [78033ae] Remove ToUserId in blast ws fan-out (#9615) Reed [661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn [3f325be] [QA-1537] Remove unnecessary short circuit logic for gated tracks in get_remixes_of (#9613) Randy Schott [e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers
schottra
added a commit
that referenced
this pull request
Sep 4, 2024
…ient-v1-feed * origin/main: (53 commits) Show content title in chat blast item (#9627) Revert change to create-audius-app until new SDK version is published (#9632) [C-4752] Reduce border width for small Avatar (#9612) [QA-1512] Mediorum transcode fixes (#9631) [C-4952] Mobile comment overflow action confirmations (#9622) Audius Protocol v0.6.183 [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Fix purchasing without network split (#9629) Pin Rust version for 'prod' DN dockerfile (#9607) [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) [QA-1439] Don't block gated tracks from being remixes (#9620) [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) [C-5008] Add single and multi lineHeight options to Text (#9610) Blast getMessages supports all audiences (#9618) [PAY-3378] Disable blast audiences radios with no recipients (#9619) Only add blasts to store for sender (#9617) [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Remove ToUserId in blast ws fan-out (#9615) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug was that in the query (line 125 in same file) we were using
blast_id || chat_idas the message_id, but then in the fan-outs we were usingchat_id + blast_id. We should use the same ordering everywhere and respect the ordering in the db.How Has This Been Tested?
Confirmed bug repro on local dev without fix, confirmed fix eliminated bug.