[QA-1512] Mediorum transcode fixes #9631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since only StoreAll nodes will attempt missed jobs, this should be fine.
|
stereosteve
changed the title
raymondjacobson
approved these changes
Sep 4, 2024
mediorum/server/repair.go
Outdated
| wasReplicatedThisWeek := attrs.CreateTime.After(time.Now().Add(-24 * 7 * time.Hour)) | ||
|
|
||
| if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek { | ||
| if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor*3 && !wasReplicatedThisWeek { |
Member
There was a problem hiding this comment.
*3 again? are we worried this is too much commitment?
Contributor
Author
There was a problem hiding this comment.
Added a commit to make the threshold dynamic based on free disk space. So nodes with larger disks can accommodate files that can't be placed on smaller nodes. Just guessed at numbers for now based on looking at healthz.
stereosteve
added a commit
that referenced
this pull request
Sep 4, 2024
schottra
added a commit
that referenced
this pull request
Sep 4, 2024
…ient-v1-feed * origin/main: (53 commits) Show content title in chat blast item (#9627) Revert change to create-audius-app until new SDK version is published (#9632) [C-4752] Reduce border width for small Avatar (#9612) [QA-1512] Mediorum transcode fixes (#9631) [C-4952] Mobile comment overflow action confirmations (#9622) Audius Protocol v0.6.183 [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Fix purchasing without network split (#9629) Pin Rust version for 'prod' DN dockerfile (#9607) [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) [QA-1439] Don't block gated tracks from being remixes (#9620) [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) [C-5008] Add single and multi lineHeight options to Text (#9610) Blast getMessages supports all audiences (#9618) [PAY-3378] Disable blast audiences radios with no recipients (#9619) Only add blasts to store for sender (#9617) [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Remove ToUserId in blast ws fan-out (#9615) ...
audius-infra
pushed a commit
that referenced
this pull request
Sep 5, 2024
[0902048] Add stems api for v1 (#9513) Raymond Jacobson [dda5524] Add createUserBankIfNeeded call to trending rewards bug (#9634) Raymond Jacobson [b80df23] Revert "Cycle solana RPC connections better (#9147)" (#9635) Raymond Jacobson [adf2207] [PAY-3370] Always use encoded content IDs in chats (#9636) Reed [53e78ae] getChatMessages respects audience content type and id (#9628) Reed [355c7a9] [QA-1512] Mediorum transcode fixes (#9631) Steve Perkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hash migration broke some assumptions around retry logic for transcode jobs... which was causing a lot of crud spam with failures.
We were planning to get rid of all this "implicit work queue" stuff and move transcode inline to upload request... which I think makes more sense now.
This is a temporary fix to only do retry logic to StoreAll nodes so as to cut down on the crud spam.