[C-4952] Mobile comment overflow action confirmations #9622

sliptype · 2024-09-03T22:21:15Z

Description

Add confirmation drawers for comment overflow actions
Add comment badges
Tweak default ConfirmationDrawer props per design. Cancel button is now "Cancel" and no icon is shown in the header by default

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

changeset-bot · 2024-09-03T22:21:19Z

⚠️ No Changeset found

Latest commit: fabf55c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-09-03T22:21:22Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	`3be87b4`	dev-tools/config.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-09-03T22:34:45Z

Preview this change https://demo.audius.co/sk-c-pinning

dylanjeffers

Nice! Not sure how those overflow perform with all those drawer elements sitting there for every comment?

dylanjeffers · 2024-09-03T22:32:38Z

packages/mobile/src/components/comments/CommentBlock.tsx

-                  </Text>
+      <Flex gap='xs' w='100%' alignItems='flex-start' style={{ flexShrink: 1 }}>
+        <Box style={{ position: 'absolute', top: 0, right: 0 }}>
+          <CommentBadges


Maybe this just called comment badge?

I pulled this from web and it looks like CommentBadge is already used as the internal component that gets rendered based on the badge type. But I can update!

dylanjeffers · 2024-09-03T22:33:21Z

packages/mobile/src/components/comments/CommentOverflowMenu.tsx

+            onConfirm={handlePinComment}
+          />
+        ) : null}
+


This is quite a file lol

Yeah I have some ideas for a refactor that I can do!

dylanjeffers · 2024-09-03T22:34:52Z

packages/mobile/src/components/drawers/ConfirmationDrawerWithoutRedux.tsx

+  SetOptional<DrawerProps, 'children'>
+
+/** ConfirmationDrawer that isn't coupled to redux */
+export const ConfirmationDrawerWithoutRedux = (


Could this just be part of the existing confirmation drawer file, since that has the web redux vs native redux stuff right?

I wanted to keep it separate to make it obvious that the behavior is different, also following the same pattern with ActionDrawerWithoutRedux

…ient-v1-feed * origin/main: (53 commits) Show content title in chat blast item (#9627) Revert change to create-audius-app until new SDK version is published (#9632) [C-4752] Reduce border width for small Avatar (#9612) [QA-1512] Mediorum transcode fixes (#9631) [C-4952] Mobile comment overflow action confirmations (#9622) Audius Protocol v0.6.183 [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Fix purchasing without network split (#9629) Pin Rust version for 'prod' DN dockerfile (#9607) [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) [QA-1439] Don't block gated tracks from being remixes (#9620) [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) [C-5008] Add single and multi lineHeight options to Text (#9610) Blast getMessages supports all audiences (#9618) [PAY-3378] Disable blast audiences radios with no recipients (#9619) Only add blasts to store for sender (#9617) [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Remove ToUserId in blast ws fan-out (#9615) ...

[34d5a5a] [PAY-3213] ChatListBlastItem mobile UI (#9656) Reed [518f4d8] fix typecheck on main (#9669) Andrew Mendelsohn [f183d96] fix type for spl_usdc_payout_wallet on user adapter (#9667) Randy Schott [dab6070] [QA-1528] Move audius-query force ref tracking to useState (#9661) Andrew Mendelsohn [d9022cb] fix typecheck in ChatBlastSelectAudienceFields (#9668) Andrew Mendelsohn [cdb428a] [QA-1529] Add guard for -1 ids to audius-query api hooks (#9647) Andrew Mendelsohn [ec1dd85] [QA-1542] Fix mobile top supporters crashing profile page (#9646) Andrew Mendelsohn [7f49a62] [PAY-3416] Adds v1 account endpoint (#9651) Randy Schott [807d569] [C-5009] Add debug theme (#9611) Dylan Jeffers [9f75690] [C-5005] Add comment counts (#9630) Dylan Jeffers [dc74998] [C-4872, C-4993, QA-1538] Add ComposerInput component and update comments and DMs to user the input (#9638) Kyle Shanks [2bec1f2] [PAY-3420] Update styles on checkout UI (#9649) Raymond Jacobson [d90eeac] [QA-1545] Fix cover art size on album search results (#9654) Raymond Jacobson [842a762] Set audienceContentType=track for remix chat blasts (#9655) Reed [0e6b44e] [C-4975] Comments pagination (#9633) JD Francis [85fe0e7] Display audience counts in chat blast items (#9640) Reed [8236a47] [PAY-3401] Consolidate pay with anything tx (#9645) Raymond Jacobson [f897d8f] [PAY-3411] Enable monetization for everyone when network cut is enabled (#9644) Marcus Pasell [0902048] Add stems api for v1 (#9513) Raymond Jacobson [d04bf16] [C-4956] Add mobile comments sort ui (#9637) Sebastian Klingler [b915249] Fix purchasers count in chat blast modal (#9639) Reed [adf2207] [PAY-3370] Always use encoded content IDs in chats (#9636) Reed [53fe54e] [PAY-3388] Migrate feed to SDK (#9593) Randy Schott [59435ae] Show content title in chat blast item (#9627) Reed [824fc47] [C-4752] Reduce border width for small Avatar (#9612) Dylan Jeffers [fa9b498] [C-4952] Mobile comment overflow action confirmations (#9622) Sebastian Klingler [065e8b8] [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) Marcus Pasell [04f810a] [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Marcus Pasell [fdc7cf3] Fix purchasing without network split (#9629) Marcus Pasell [682e7d4] [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) Marcus Pasell [2e621bb] [QA-1439] Don't block gated tracks from being remixes (#9620) Andrew Mendelsohn [cb753b3] [C-5008] Add single and multi lineHeight options to Text (#9610) Dylan Jeffers [11911da] [PAY-3378] Disable blast audiences radios with no recipients (#9619) Reed [826d3ae] Only add blasts to store for sender (#9617) Reed [661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn [f365f01] Add support for expand rounding mode to FixedDecimal (#9606) Marcus Pasell [d6344cb] Fix web external-text-link style propagation (#9609) Dylan Jeffers [90b3b41] [PAY-3324] Add copy notice around network take rate (#9608) Marcus Pasell [d876547] Release mobile apps to 113 (#9614) Dylan Jeffers [e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers [66b1e99] Fix broken common tests (#9605) Marcus Pasell

sliptype added 15 commits August 27, 2024 14:54

Styling fixes

233e860

Loading state

5f2b766

Allow scrolling at all snap points

cc2eeb6

Improve bottom sheet scrolling behavior

ce79df0

Replying

12a836f

Merge branch 'main' into sk-c-4949-comments-styling-loading

3be87b4

Editing

f2154fa

Merge issue

b839c82

Lint fix

ce7508f

Improve height calculation

2c7afff

Merge branch 'main' into sk-c-4949-comments-styling-loading

0ee45a8

[WIP] pinning and deleting

9e83544

Add ui for remaining overflow actions

dcd1d71

Merge branch 'main' into sk-c-pinning

ada4c44

Merge fixes

ff2ecde

sliptype requested review from a team, DejayJD and dylanjeffers September 3, 2024 22:21

pull-request-size bot added the size/L label Sep 3, 2024

dylanjeffers approved these changes Sep 3, 2024

View reviewed changes

Address pr comments

fabf55c

sliptype merged commit fa9b498 into main Sep 4, 2024

sliptype deleted the sk-c-pinning branch September 4, 2024 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-4952] Mobile comment overflow action confirmations #9622

[C-4952] Mobile comment overflow action confirmations #9622

Uh oh!

sliptype commented Sep 3, 2024

Uh oh!

changeset-bot bot commented Sep 3, 2024 •

edited

Loading

Uh oh!

gitguardian bot commented Sep 3, 2024 •

edited

Loading

Uh oh!

audius-infra commented Sep 3, 2024

Uh oh!

dylanjeffers left a comment

Uh oh!

dylanjeffers Sep 3, 2024

Uh oh!

sliptype Sep 4, 2024

Uh oh!

dylanjeffers Sep 3, 2024

Uh oh!

sliptype Sep 4, 2024

Uh oh!

dylanjeffers Sep 3, 2024

Uh oh!

sliptype Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[C-4952] Mobile comment overflow action confirmations #9622

[C-4952] Mobile comment overflow action confirmations #9622

Uh oh!

Conversation

sliptype commented Sep 3, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardian bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

audius-infra commented Sep 3, 2024

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Sep 3, 2024 •

edited

Loading

gitguardian bot commented Sep 3, 2024 •

edited

Loading