[PAY-3206] Populate content targeting dropdowns for blast modal (web) #9601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60fb183 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Preview this change https://demo.audius.co/am-PAY-3206 |
dharit-tan
reviewed
Sep 3, 2024
| @ns.expect(sales_aggregate_parser) | ||
| @auth_middleware(sales_aggregate_parser) | ||
| @auth_middleware(sales_aggregate_parser, require_auth=True) | ||
| @ns.marshal_with(sales_aggregate_response) |
Contributor
There was a problem hiding this comment.
should probably run npm run changeset for the api updates
dharit-tan
reviewed
Sep 3, 2024
| }) | ||
| const { data: remixersCount } = useGetRemixersCount({ | ||
| userId: currentUserId, | ||
| userId: currentUserId!, |
Contributor
There was a problem hiding this comment.
wondering if there's a way around the !
schottra
reviewed
Sep 3, 2024
| const sdk = await audiusSdk() | ||
| const { data } = await sdk.full.users.getPurchasersCount({ | ||
| id: encodeHashId(userId), | ||
| contentId: contentId ? Id.parse(contentId) : undefined, |
Contributor
There was a problem hiding this comment.
You can use OptionalId.parse() if the value might be missing. It doesn't throw in that case.
schottra
reviewed
Sep 3, 2024
| ) => { | ||
| const sdk = await audiusSdk() | ||
| const { data } = await sdk.full.users.getPurchasersCount({ | ||
| id: encodeHashId(userId), |
Contributor
There was a problem hiding this comment.
Also since I'm here:
nit: use Id.parse() for this :-D
audius-infra
pushed a commit
that referenced
this pull request
Sep 4, 2024
[6755daa] Pin Rust version for 'prod' DN dockerfile (#9607) Marcus Pasell [aa766ce] [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626) Marcus Pasell [b904856] [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621) Reed [0deaa00] Blast getMessages supports all audiences (#9618) Reed [62a4937] [PAY-3387] Chat ws respects chat_member.is_hidden (#9616) Reed [78033ae] Remove ToUserId in blast ws fan-out (#9615) Reed [661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn [3f325be] [QA-1537] Remove unnecessary short circuit logic for gated tracks in get_remixes_of (#9613) Randy Schott [e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers
audius-infra
pushed a commit
that referenced
this pull request
Sep 7, 2024
[34d5a5a] [PAY-3213] ChatListBlastItem mobile UI (#9656) Reed [518f4d8] fix typecheck on main (#9669) Andrew Mendelsohn [f183d96] fix type for spl_usdc_payout_wallet on user adapter (#9667) Randy Schott [dab6070] [QA-1528] Move audius-query force ref tracking to useState (#9661) Andrew Mendelsohn [d9022cb] fix typecheck in ChatBlastSelectAudienceFields (#9668) Andrew Mendelsohn [cdb428a] [QA-1529] Add guard for -1 ids to audius-query api hooks (#9647) Andrew Mendelsohn [ec1dd85] [QA-1542] Fix mobile top supporters crashing profile page (#9646) Andrew Mendelsohn [7f49a62] [PAY-3416] Adds v1 account endpoint (#9651) Randy Schott [807d569] [C-5009] Add debug theme (#9611) Dylan Jeffers [9f75690] [C-5005] Add comment counts (#9630) Dylan Jeffers [dc74998] [C-4872, C-4993, QA-1538] Add ComposerInput component and update comments and DMs to user the input (#9638) Kyle Shanks [2bec1f2] [PAY-3420] Update styles on checkout UI (#9649) Raymond Jacobson [d90eeac] [QA-1545] Fix cover art size on album search results (#9654) Raymond Jacobson [842a762] Set audienceContentType=track for remix chat blasts (#9655) Reed [0e6b44e] [C-4975] Comments pagination (#9633) JD Francis [85fe0e7] Display audience counts in chat blast items (#9640) Reed [8236a47] [PAY-3401] Consolidate pay with anything tx (#9645) Raymond Jacobson [f897d8f] [PAY-3411] Enable monetization for everyone when network cut is enabled (#9644) Marcus Pasell [0902048] Add stems api for v1 (#9513) Raymond Jacobson [d04bf16] [C-4956] Add mobile comments sort ui (#9637) Sebastian Klingler [b915249] Fix purchasers count in chat blast modal (#9639) Reed [adf2207] [PAY-3370] Always use encoded content IDs in chats (#9636) Reed [53fe54e] [PAY-3388] Migrate feed to SDK (#9593) Randy Schott [59435ae] Show content title in chat blast item (#9627) Reed [824fc47] [C-4752] Reduce border width for small Avatar (#9612) Dylan Jeffers [fa9b498] [C-4952] Mobile comment overflow action confirmations (#9622) Sebastian Klingler [065e8b8] [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) Marcus Pasell [04f810a] [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Marcus Pasell [fdc7cf3] Fix purchasing without network split (#9629) Marcus Pasell [682e7d4] [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) Marcus Pasell [2e621bb] [QA-1439] Don't block gated tracks from being remixes (#9620) Andrew Mendelsohn [cb753b3] [C-5008] Add single and multi lineHeight options to Text (#9610) Dylan Jeffers [11911da] [PAY-3378] Disable blast audiences radios with no recipients (#9619) Reed [826d3ae] Only add blasts to store for sender (#9617) Reed [661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn [f365f01] Add support for expand rounding mode to FixedDecimal (#9606) Marcus Pasell [d6344cb] Fix web external-text-link style propagation (#9609) Dylan Jeffers [90b3b41] [PAY-3324] Add copy notice around network take rate (#9608) Marcus Pasell [d876547] Release mobile apps to 113 (#9614) Dylan Jeffers [e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers [66b1e99] Fix broken common tests (#9605) Marcus Pasell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds requisite endpoints to audius-query api
Populates dropdowns for purchased content and remix track dropdowns
Dynamic user audience count based on selected content
Had to do some hashId encoding to call the sdk endpoints. I feel like that shouldn't be necessary, so maybe worth looking into that
How Has This Been Tested?
Working locally with different selected tracks