Skip to content

[PAY-3388] Migrate feed to SDK#9593

Merged
schottra merged 7 commits intomainfrom
pay-3388-implement-client-v1-feed
Sep 4, 2024
Merged

[PAY-3388] Migrate feed to SDK#9593
schottra merged 7 commits intomainfrom
pay-3388-implement-client-v1-feed

Conversation

@schottra
Copy link
Contributor

@schottra schottra commented Aug 30, 2024 •
edited
Loading

Description

This uses the newly-added /v1/users/<id>/feed endpoint via SDK instead of the legacy query through API Client.
The return types are quite different as the legacy endpoint didn't use a marshaler to exclude fields from the response. But it should be compatible.

How Has This Been Tested?

Verified diff with compareSDKResponse. Tracks/Collections returned in the response looked okay.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6699539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

audius-infra commented Aug 30, 2024

Preview this change https://demo.audius.co/pay-3388-implement-client-v1-feed

@schottra schottra marked this pull request as ready for review September 4, 2024 15:15
sliptype
sliptype approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big moves

packages/discovery-provider/src/api/v1/helpers.py
if item.get("playlist_id"):
extended_playlist = extend_playlist(item)
# TODO: https://linear.app/audius/issue/PAY-3398/fix-playlist-contents-serialization
extended_playlist["playlist_contents"] = extended_playlist["added_timestamps"]
Copy link
Contributor

@sliptype sliptype Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh another one 😖

Copy link
Contributor Author

@schottra schottra Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, I added a ticket with a plan to address it 😁

packages/common/src/services/explore/Explore.ts
Copy link
Contributor

@sliptype sliptype Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know we had an Explore service

Copy link
Contributor Author

@schottra schottra Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me either! I think it's only used in one place, if at all.

packages/web/src/common/store/pages/feed/lineup/sagas.ts
type FeedItem = LineupTrack | Collection

const filterMap = {
const filterMap: { [k in FeedFilter]: full.GetUserFeedFilterEnum } = {
Copy link
Contributor

@sliptype sliptype Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you achieve the same with as const?

Copy link
Contributor Author

@schottra schottra Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh potentially. I never use as const but the goal was to make sure this breaks if we don't have an item for each key in the enum

@schottra
Merge remote-tracking branch 'origin/main' into pay-3388-implement-cl…
6699539 
…ient-v1-feed

* origin/main: (53 commits)
  Show content title in chat blast item (#9627)
  Revert change to create-audius-app until new SDK version is published (#9632)
  [C-4752] Reduce border width for small Avatar (#9612)
  [QA-1512] Mediorum transcode fixes (#9631)
  [C-4952] Mobile comment overflow action confirmations (#9622)
  Audius Protocol v0.6.183
  [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624)
  [PAY-3404] Fix floor() for negative numbers that are already floored (#9623)
  Fix purchasing without network split (#9629)
  Pin Rust version for 'prod' DN dockerfile (#9607)
  [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625)
  [PAY-3412] Include network splits in CSV downloads of sales/purchases (#9626)
  [QA-1439] Don't block gated tracks from being remixes (#9620)
  [PAY-3389] Fix duplicate blast messages in 1:1 threads (#9621)
  [C-5008] Add single and multi lineHeight options to Text (#9610)
  Blast getMessages supports all audiences (#9618)
  [PAY-3378] Disable blast audiences radios with no recipients (#9619)
  Only add blasts to store for sender (#9617)
  [PAY-3387] Chat ws respects chat_member.is_hidden (#9616)
  Remove ToUserId in blast ws fan-out (#9615)
  ...
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Sep 4, 2024
@schottra schottra enabled auto-merge (squash) September 4, 2024 17:21
@audius-infra
Copy link
Collaborator

audius-infra commented Sep 4, 2024

Preview this change https://demo.audius.co/pay-3388-implement-client-v1-feed

@schottra schottra merged commit 53fe54e into main Sep 4, 2024
@schottra schottra deleted the pay-3388-implement-client-v1-feed branch September 4, 2024 17:52
audius-infra pushed a commit that referenced this pull request Sep 7, 2024
Audius Client (Web and Mobile) v1.5.98
73b5ec0 
[34d5a5a] [PAY-3213] ChatListBlastItem mobile UI (#9656) Reed
[518f4d8] fix typecheck on main (#9669) Andrew Mendelsohn
[f183d96] fix type for spl_usdc_payout_wallet on user adapter (#9667) Randy Schott
[dab6070] [QA-1528] Move audius-query force ref tracking to useState (#9661) Andrew Mendelsohn
[d9022cb] fix typecheck in ChatBlastSelectAudienceFields (#9668) Andrew Mendelsohn
[cdb428a] [QA-1529] Add guard for -1 ids to audius-query api hooks (#9647) Andrew Mendelsohn
[ec1dd85] [QA-1542] Fix mobile top supporters crashing profile page (#9646) Andrew Mendelsohn
[7f49a62] [PAY-3416] Adds v1 account endpoint (#9651) Randy Schott
[807d569] [C-5009] Add debug theme (#9611) Dylan Jeffers
[9f75690] [C-5005] Add comment counts (#9630) Dylan Jeffers
[dc74998] [C-4872, C-4993, QA-1538] Add ComposerInput component and update comments and DMs to user the input (#9638) Kyle Shanks
[2bec1f2] [PAY-3420] Update styles on checkout UI (#9649) Raymond Jacobson
[d90eeac] [QA-1545] Fix cover art size on album search results (#9654) Raymond Jacobson
[842a762] Set audienceContentType=track for remix chat blasts (#9655) Reed
[0e6b44e] [C-4975] Comments pagination (#9633) JD Francis
[85fe0e7] Display audience counts in chat blast items (#9640) Reed
[8236a47] [PAY-3401] Consolidate pay with anything tx (#9645) Raymond Jacobson
[f897d8f] [PAY-3411] Enable monetization for everyone when network cut is enabled (#9644) Marcus Pasell
[0902048] Add stems api for v1 (#9513) Raymond Jacobson
[d04bf16] [C-4956] Add mobile comments sort ui (#9637) Sebastian Klingler
[b915249] Fix purchasers count in chat blast modal (#9639) Reed
[adf2207] [PAY-3370] Always use encoded content IDs in chats (#9636) Reed
[53fe54e] [PAY-3388] Migrate feed to SDK (#9593) Randy Schott
[59435ae] Show content title in chat blast item (#9627) Reed
[824fc47] [C-4752] Reduce border width for small Avatar (#9612) Dylan Jeffers
[fa9b498] [C-4952] Mobile comment overflow action confirmations (#9622) Sebastian Klingler
[065e8b8] [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) Marcus Pasell
[04f810a] [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Marcus Pasell
[fdc7cf3] Fix purchasing without network split (#9629) Marcus Pasell
[682e7d4] [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) Marcus Pasell
[2e621bb] [QA-1439] Don't block gated tracks from being remixes (#9620) Andrew Mendelsohn
[cb753b3] [C-5008] Add single and multi lineHeight options to Text (#9610) Dylan Jeffers
[11911da] [PAY-3378] Disable blast audiences radios with no recipients (#9619) Reed
[826d3ae] Only add blasts to store for sender (#9617) Reed
[661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn
[f365f01] Add support for expand rounding mode to FixedDecimal (#9606) Marcus Pasell
[d6344cb] Fix web external-text-link style propagation (#9609) Dylan Jeffers
[90b3b41] [PAY-3324] Add copy notice around network take rate (#9608) Marcus Pasell
[d876547] Release mobile apps to 113 (#9614) Dylan Jeffers
[e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers
[66b1e99] Fix broken common tests (#9605) Marcus Pasell
schottra added a commit that referenced this pull request Sep 14, 2024
@schottra
Revert "[PAY-3388] Migrate feed to SDK (#9593)"
c3c6226 
This reverts commit 53fe54e.
schottra added a commit that referenced this pull request Sep 14, 2024
@schottra
Revert "[PAY-3388] Migrate feed to SDK (#9593)"
429d286 
This reverts commit 53fe54e.
raymondjacobson pushed a commit that referenced this pull request Sep 16, 2024
@schottra
Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754)
921f74d
raymondjacobson pushed a commit that referenced this pull request Sep 16, 2024
@schottra @raymondjacobson
Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754)
50548ff
audius-infra pushed a commit that referenced this pull request Sep 21, 2024
Audius Client (Web and Mobile) v1.5.100
d61c5e6 
[e28b82b] Add client support for single transaction reward claiming (#9801) Marcus Pasell
[1696b04] Version Packages (#9772) github-actions[bot]
[1c2edae] Reapply libs split (#9817) Sebastian Klingler
[c9f1142] [C-5026] Optimistic UI tweaks (web only for now) (#9816) JD Francis
[7c4b196] Don't show empty chat prompt for blasts (#9815) Reed
[7ef38cd] [QA-1732] Undo test code to fix unread pill check for notifications (#9814) Kyle Shanks
[ad274d8] [PAY-3214] Add CreateBlast CTA to followers and supporters user lists (web) (#9804) Andrew Mendelsohn
[3f862a8] UDF for chat_allowed (#9789) Steve Perkins
[fa1da71] revert max width on chats (#9806) Andrew Mendelsohn
[6074a68] [PAY-3216] Update upload share buttons (#9805) Andrew Mendelsohn
[b9a8c0b] Revert libs split (#9802) Sebastian Klingler
[8c80712] Fix merge issue (#9800) Sebastian Klingler
[0ea3a11] [QA-1731] Fix key filter label (#9798) Kyle Shanks
[bc28909] Separate libs from main sdk bundle (#9791) Sebastian Klingler
[4d8ad95] Add comment email and push (#9784) Dylan Jeffers
[734f766] [QA-1717] Fix empty unfurl messages for tracks and playlists (#9795) Kyle Shanks
[2faf2e0] Add CHAT routes to static_routes (#9796) Reed
[8b28228] [C-4969] Comment tombstones (#9790) JD Francis
[e613a0b] [PAY-3215] ChatBlastCTA in own followers and supporters screens (#9793) Andrew Mendelsohn
[123403b] [PAY-3211] Chat blast audience display (mobile) (#9792) Andrew Mendelsohn
[d93fcab] [PAY-3210, PAY-3346] Chat blast audience tile (web) (#9778) Andrew Mendelsohn
[32f758d] [QA-1730] Add sort back to the search query (#9787) Kyle Shanks
[2359e1a] Chat fix quicktype (#9782) Steve Perkins
[9be9c3a] [PAY-3209] Chat blast mobile header (#9777) Reed
[9f05224] Use Harmony Artwork for ChatBlastHeader (#9785) Reed
[2d838c5] [C-5024] Add comment notification (#9781) Dylan Jeffers
[a6850d4] Handle dupe comment thread indexing (#9574) Isaac Solo
[c27a040] [C-4826] (web) Comment action confirmation modals & toasts (#9766) JD Francis
[079cd5d] Remove direct only and add noQuote error (#9780) Raymond Jacobson
[68c4084] Fix usdc-usdc purchase (#9779) Raymond Jacobson
[839e1e8] Fix harmony tests (#9775) Sebastian Klingler
[93c216b] [PAY-3367] Mobile chat blast audience/content selection (#9683) Reed
[c6bb074] [PAY-3208] Web chat blast header (#9767) Reed
[bfd9c38] Version Packages (#8915) github-actions[bot]
[afc5416] [C-4970, C-4825] Add comment reports (#9680) Dylan Jeffers
[f38fb31] Improve mobile profile spacing (#9758) Dylan Jeffers
[74ed02a] Fix typecheck (#9768) Sebastian Klingler
[38a5f29] [C-1601] Fix verified badge, Improve text-link (#9757) Dylan Jeffers
[b6b0827] [C-5014] Remove search input auto-correct (#9756) Dylan Jeffers
[d7c8a4c] [C-4973] Add edit comment e2e (#9679) Dylan Jeffers
[5c839b9] Harmonize web challenge UI (#9762) Reed
[94f614d] Fix composer input error and styling for DMs (#9765) Kyle Shanks
[99fb10f] [C-4971] Add comment pin e2e (#9678) Dylan Jeffers
[59c2d6e] [C-4988] Update mobile TrackScreen layout for remixes + comments (#9657) Sebastian Klingler
[66b1b2c] [C-4943] Add comment sort (#9672) Dylan Jeffers
[be35c44] Fixing lint from bad merge (#9764) Kyle Shanks
[85be4f0] [QA-1326] Update challenge button labels to match spec (#9743) Reed
[8e4f02b] [C-4871] Add timestamp highlighting for composer input (#9761) Kyle Shanks
[0a67586] Add tab completion for compose UI autocomplete (#9682) Kyle Shanks
[85b27c4] [C-5020] Search filter fixes for FilterButton (#9763) Sebastian Klingler
[921f74d] Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754) Randy Schott
[fc257e1] Fix challenge summary table (#9755) Reed
[ab45d0e] [QA-1713] Add filter input to feature flag modal (#9740) Dylan Jeffers
@schottra schottra restored the pay-3388-implement-client-v1-feed branch October 2, 2024 18:58
@schottra schottra mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo Awaiting requested review from rickyrombo

1 more reviewer

@sliptype sliptype sliptype approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schottra @audius-infra @sliptype