Skip to content

Conversation

@raymondjacobson
Copy link
Member

Description

  • Transfer directly to payment router via "gift" functions in sdk
  • Remove old code
  • Make sure wrapped SOL works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

bought track + album on staging with USDC, SOL, and WIF

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: 00e06f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

].filter(Boolean) as TransactionInstruction[]
})

transaction = new VersionedTransaction(message.compileToV0Message())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be easier to use buildTransaction on solanaClient w/ sourceWallet as fee payer - can also set priority

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/rj-pay-3401

@raymondjacobson
Copy link
Member Author

chatted offline with @rickyrombo - made the changes to clean up the sdk layer. There is still some complexity in the sagas, but I think that's necessary.

Latest commit here changes the getPurchaseTransaction method into a getPurchaseInstructions method and uses that for payw/anything and coinflow checkout.

while marcus is out, @dharit-tan if you could help review that'd be great <3

@raymondjacobson
Copy link
Member Author

To test:

  • Buy album with $WIF, $wrappedSOL, $USDC
  • Buy track with ^
  • Buy track with coinflow
  • Buy album with coinflow

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/rj-pay-3401

Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@raymondjacobson raymondjacobson merged commit 8236a47 into main Sep 5, 2024
@raymondjacobson raymondjacobson deleted the rj-pay-3401 branch September 5, 2024 17:05
audius-infra pushed a commit that referenced this pull request Sep 7, 2024
[34d5a5a] [PAY-3213] ChatListBlastItem mobile UI (#9656) Reed
[518f4d8] fix typecheck on main (#9669) Andrew Mendelsohn
[f183d96] fix type for spl_usdc_payout_wallet on user adapter (#9667) Randy Schott
[dab6070] [QA-1528] Move audius-query force ref tracking to useState (#9661) Andrew Mendelsohn
[d9022cb] fix typecheck in ChatBlastSelectAudienceFields (#9668) Andrew Mendelsohn
[cdb428a] [QA-1529] Add guard for -1 ids to audius-query api hooks (#9647) Andrew Mendelsohn
[ec1dd85] [QA-1542] Fix mobile top supporters crashing profile page (#9646) Andrew Mendelsohn
[7f49a62] [PAY-3416] Adds v1 account endpoint (#9651) Randy Schott
[807d569] [C-5009] Add debug theme (#9611) Dylan Jeffers
[9f75690] [C-5005] Add comment counts (#9630) Dylan Jeffers
[dc74998] [C-4872, C-4993, QA-1538] Add ComposerInput component and update comments and DMs to user the input (#9638) Kyle Shanks
[2bec1f2] [PAY-3420] Update styles on checkout UI (#9649) Raymond Jacobson
[d90eeac] [QA-1545] Fix cover art size on album search results (#9654) Raymond Jacobson
[842a762] Set audienceContentType=track for remix chat blasts (#9655) Reed
[0e6b44e] [C-4975] Comments pagination (#9633) JD Francis
[85fe0e7] Display audience counts in chat blast items (#9640) Reed
[8236a47] [PAY-3401] Consolidate pay with anything tx (#9645) Raymond Jacobson
[f897d8f] [PAY-3411] Enable monetization for everyone when network cut is enabled (#9644) Marcus Pasell
[0902048] Add stems api for v1 (#9513) Raymond Jacobson
[d04bf16] [C-4956] Add mobile comments sort ui (#9637) Sebastian Klingler
[b915249] Fix purchasers count in chat blast modal (#9639) Reed
[adf2207] [PAY-3370] Always use encoded content IDs in chats (#9636) Reed
[53fe54e] [PAY-3388] Migrate feed to SDK (#9593) Randy Schott
[59435ae] Show content title in chat blast item (#9627) Reed
[824fc47] [C-4752] Reduce border width for small Avatar (#9612) Dylan Jeffers
[fa9b498] [C-4952] Mobile comment overflow action confirmations (#9622) Sebastian Klingler
[065e8b8] [PAY-3408][PAY-3409][PAY-3408][PAY-3405][PAY-3413] Update Sales/Purchase Modal (#9624) Marcus Pasell
[04f810a] [PAY-3404] Fix floor() for negative numbers that are already floored (#9623) Marcus Pasell
[fdc7cf3] Fix purchasing without network split (#9629) Marcus Pasell
[682e7d4] [PAY-3410][PAY-3406] Update Sales Table help link and "Value" => "Total" (#9625) Marcus Pasell
[2e621bb] [QA-1439] Don't block gated tracks from being remixes (#9620) Andrew Mendelsohn
[cb753b3] [C-5008] Add single and multi lineHeight options to Text (#9610) Dylan Jeffers
[11911da] [PAY-3378] Disable blast audiences radios with no recipients (#9619) Reed
[826d3ae] Only add blasts to store for sender (#9617) Reed
[661cca7] [PAY-3206] Populate content targeting dropdowns for blast modal (web) (#9601) Andrew Mendelsohn
[f365f01] Add support for expand rounding mode to FixedDecimal (#9606) Marcus Pasell
[d6344cb] Fix web external-text-link style propagation (#9609) Dylan Jeffers
[90b3b41] [PAY-3324] Add copy notice around network take rate (#9608) Marcus Pasell
[d876547] Release mobile apps to 113 (#9614) Dylan Jeffers
[e9091d8] [C-5001] Add comment disabling for tracks (#9594) Dylan Jeffers
[66b1e99] Fix broken common tests (#9605) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants