[PAY-3367] Mobile chat blast audience/content selection#9683

dharit-tan · 2024-09-09T23:26:26Z

Description

Refactor to shared hooks
Re-usable screen for content selection

How Has This Been Tested?

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-09.at.18.14.04.mp4

changeset-bot · 2024-09-09T23:26:30Z

⚠️ No Changeset found

Latest commit: f6ef9ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-09-09T23:43:36Z

Preview this change https://demo.audius.co/rt-mobile-select-audience

…ence

audius-infra · 2024-09-17T16:44:44Z

Preview this change https://demo.audius.co/rt-mobile-select-audience

amendelsohn

Awesome! Looks great!

packages/common/src/hooks/chats/useRemixersAudience.ts

packages/mobile/src/screens/create-chat-blast-screen/ChatBlastSelectAudienceFields.tsx

amendelsohn · 2024-09-17T17:59:57Z

packages/mobile/src/screens/create-chat-blast-screen/ChatBlastSelectAudienceFields.tsx

  const { data: user } = useGetCurrentUser()
  const [{ value: targetAudience }] = useField(TARGET_AUDIENCE_FIELD)
  const isSelected = targetAudience === ChatBlastAudience.FOLLOWERS
+  const isDisabled = user?.follower_count === 0


I don't think you can get to this screen when user is undefined, but if we want to be extra careful, we can update the condition here

wdym? user && user.follower_count === 0? i think undefined === 0 comes out to false?

yeah so disabled would be false. Wouldn't we want isDisabled: true when there's no user also?

Again, I don't think it's possible to get here without a user though, since it's behind the CTA?

u right i was inverted

packages/mobile/src/screens/create-chat-blast-screen/ChatBlastSelectAudienceFields.tsx

packages/mobile/src/screens/create-chat-blast-screen/ChatBlastSelectAudienceScreen.tsx

packages/mobile/src/screens/create-chat-blast-screen/ChatBlastSelectContentScreen.tsx

amendelsohn · 2024-09-17T18:14:34Z

packages/mobile/src/screens/form-screen/FormScreen.tsx

        backgroundColor='white'
        borderTop='default'
        gap='m'
+        style={css({ position: 'absolute', bottom: 0, left: 0, right: 0 })}


looks ok to me, but we should check this doesn't break other screens

oo good call - it breaks things! with this absolute position, other usages of FormScreen have the same problem i was running into where the footer overlaps some of the options.
height: 70% fixes this on the ChatBlastSelectContentScreen so will leave it at that for now.

audius-infra · 2024-09-17T19:18:28Z

Preview this change https://demo.audius.co/rt-mobile-select-audience

audius-infra · 2024-09-17T19:38:02Z

Preview this change https://demo.audius.co/rt-mobile-select-audience

[e28b82b] Add client support for single transaction reward claiming (#9801) Marcus Pasell [1696b04] Version Packages (#9772) github-actions[bot] [1c2edae] Reapply libs split (#9817) Sebastian Klingler [c9f1142] [C-5026] Optimistic UI tweaks (web only for now) (#9816) JD Francis [7c4b196] Don't show empty chat prompt for blasts (#9815) Reed [7ef38cd] [QA-1732] Undo test code to fix unread pill check for notifications (#9814) Kyle Shanks [ad274d8] [PAY-3214] Add CreateBlast CTA to followers and supporters user lists (web) (#9804) Andrew Mendelsohn [3f862a8] UDF for chat_allowed (#9789) Steve Perkins [fa1da71] revert max width on chats (#9806) Andrew Mendelsohn [6074a68] [PAY-3216] Update upload share buttons (#9805) Andrew Mendelsohn [b9a8c0b] Revert libs split (#9802) Sebastian Klingler [8c80712] Fix merge issue (#9800) Sebastian Klingler [0ea3a11] [QA-1731] Fix key filter label (#9798) Kyle Shanks [bc28909] Separate libs from main sdk bundle (#9791) Sebastian Klingler [4d8ad95] Add comment email and push (#9784) Dylan Jeffers [734f766] [QA-1717] Fix empty unfurl messages for tracks and playlists (#9795) Kyle Shanks [2faf2e0] Add CHAT routes to static_routes (#9796) Reed [8b28228] [C-4969] Comment tombstones (#9790) JD Francis [e613a0b] [PAY-3215] ChatBlastCTA in own followers and supporters screens (#9793) Andrew Mendelsohn [123403b] [PAY-3211] Chat blast audience display (mobile) (#9792) Andrew Mendelsohn [d93fcab] [PAY-3210, PAY-3346] Chat blast audience tile (web) (#9778) Andrew Mendelsohn [32f758d] [QA-1730] Add sort back to the search query (#9787) Kyle Shanks [2359e1a] Chat fix quicktype (#9782) Steve Perkins [9be9c3a] [PAY-3209] Chat blast mobile header (#9777) Reed [9f05224] Use Harmony Artwork for ChatBlastHeader (#9785) Reed [2d838c5] [C-5024] Add comment notification (#9781) Dylan Jeffers [a6850d4] Handle dupe comment thread indexing (#9574) Isaac Solo [c27a040] [C-4826] (web) Comment action confirmation modals & toasts (#9766) JD Francis [079cd5d] Remove direct only and add noQuote error (#9780) Raymond Jacobson [68c4084] Fix usdc-usdc purchase (#9779) Raymond Jacobson [839e1e8] Fix harmony tests (#9775) Sebastian Klingler [93c216b] [PAY-3367] Mobile chat blast audience/content selection (#9683) Reed [c6bb074] [PAY-3208] Web chat blast header (#9767) Reed [bfd9c38] Version Packages (#8915) github-actions[bot] [afc5416] [C-4970, C-4825] Add comment reports (#9680) Dylan Jeffers [f38fb31] Improve mobile profile spacing (#9758) Dylan Jeffers [74ed02a] Fix typecheck (#9768) Sebastian Klingler [38a5f29] [C-1601] Fix verified badge, Improve text-link (#9757) Dylan Jeffers [b6b0827] [C-5014] Remove search input auto-correct (#9756) Dylan Jeffers [d7c8a4c] [C-4973] Add edit comment e2e (#9679) Dylan Jeffers [5c839b9] Harmonize web challenge UI (#9762) Reed [94f614d] Fix composer input error and styling for DMs (#9765) Kyle Shanks [99fb10f] [C-4971] Add comment pin e2e (#9678) Dylan Jeffers [59c2d6e] [C-4988] Update mobile TrackScreen layout for remixes + comments (#9657) Sebastian Klingler [66b1b2c] [C-4943] Add comment sort (#9672) Dylan Jeffers [be35c44] Fixing lint from bad merge (#9764) Kyle Shanks [85be4f0] [QA-1326] Update challenge button labels to match spec (#9743) Reed [8e4f02b] [C-4871] Add timestamp highlighting for composer input (#9761) Kyle Shanks [0a67586] Add tab completion for compose UI autocomplete (#9682) Kyle Shanks [85b27c4] [C-5020] Search filter fixes for FilterButton (#9763) Sebastian Klingler [921f74d] Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754) Randy Schott [fc257e1] Fix challenge summary table (#9755) Reed [ab45d0e] [QA-1713] Add filter input to feature flag modal (#9740) Dylan Jeffers

dharit-tan added 2 commits September 9, 2024 16:36

WORKING

164f1fa

Remixers working

fcbfb6c

dharit-tan requested review from amendelsohn and rickyrombo September 9, 2024 23:26

pull-request-size bot added the size/XL label Sep 9, 2024

lint + types

c85516f

Merge remote-tracking branch 'origin/main' into rt-mobile-select-audi…

9c27c45

…ence

rickyrombo approved these changes Sep 16, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into rt-mobile-select-audi…

fec8122

…ence

amendelsohn approved these changes Sep 17, 2024

View reviewed changes

andrew PR comments

5749c79

lint

f6ef9ee

dharit-tan merged commit 93c216b into main Sep 17, 2024

dharit-tan deleted the rt-mobile-select-audience branch September 17, 2024 20:59

Conversation

dharit-tan commented Sep 9, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Sep 9, 2024

Uh oh!

audius-infra commented Sep 17, 2024

Uh oh!

amendelsohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amendelsohn Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

amendelsohn Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amendelsohn Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Sep 17, 2024

Uh oh!

audius-infra commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Sep 9, 2024 •

edited

Loading