[C-4826] (web) Comment action confirmation modals & toasts#9766
[C-4826] (web) Comment action confirmation modals & toasts#9766
Conversation
|
| cancelCallback?: () => void | ||
| } | ||
|
|
||
| const commentConfirmationModal = createModal<CommentConfirmationModalState>({ |
There was a problem hiding this comment.
Do we not have a generic ConfirmationModal? we have ConfirmationDrawer on modal
There was a problem hiding this comment.
Yeah in hindsight I was just following patterns here but it makes no sense to have so many XYZConfirmationModal lol. I can re-package this one as a generic ConfirmationModal for the future.
yet another reason to refactor modals 👀
There was a problem hiding this comment.
Update: Dylan added a generic ConfirmationModal in his PR that isn't redux-managed; so I updated to use that instead!
| title: 'Pin this comment?', | ||
| body: ( | ||
| <Text color='default'> | ||
| If you already pinned a comment, this will replace it |
There was a problem hiding this comment.
Let's put all these in messages
There was a problem hiding this comment.
Moved everything into the common comments messages! avail for you to use as well 👍
There was a problem hiding this comment.
Update: I got some merge conflicts from Dylan and other's PRs on the messages so I re-organized the messages file (and updated mobile). Mainly it was getting super big and unwieldy.
Take a look and let me know if you think I should tweak it! @sliptype @dylanjeffers
https://github.com/AudiusProject/audius-protocol/pull/9766/files#diff-3a57edd66c4347eb4d4f5406d7ccc3f165fe0f42fe178ba6d1aa64973b504fc2
|
Preview this change https://demo.audius.co/jd/comments-menu-options |
…jd/comments-menu-options # Conflicts: # packages/web/src/components/comments/CommentActionBar.tsx # packages/web/src/components/comments/CommentBlock.tsx
…jd/comments-menu-options
…jd/comments-menu-options # Conflicts: # packages/web/src/components/comments/CommentActionBar.tsx
|
Preview this change https://demo.audius.co/jd/comments-menu-options |
[e28b82b] Add client support for single transaction reward claiming (#9801) Marcus Pasell [1696b04] Version Packages (#9772) github-actions[bot] [1c2edae] Reapply libs split (#9817) Sebastian Klingler [c9f1142] [C-5026] Optimistic UI tweaks (web only for now) (#9816) JD Francis [7c4b196] Don't show empty chat prompt for blasts (#9815) Reed [7ef38cd] [QA-1732] Undo test code to fix unread pill check for notifications (#9814) Kyle Shanks [ad274d8] [PAY-3214] Add CreateBlast CTA to followers and supporters user lists (web) (#9804) Andrew Mendelsohn [3f862a8] UDF for chat_allowed (#9789) Steve Perkins [fa1da71] revert max width on chats (#9806) Andrew Mendelsohn [6074a68] [PAY-3216] Update upload share buttons (#9805) Andrew Mendelsohn [b9a8c0b] Revert libs split (#9802) Sebastian Klingler [8c80712] Fix merge issue (#9800) Sebastian Klingler [0ea3a11] [QA-1731] Fix key filter label (#9798) Kyle Shanks [bc28909] Separate libs from main sdk bundle (#9791) Sebastian Klingler [4d8ad95] Add comment email and push (#9784) Dylan Jeffers [734f766] [QA-1717] Fix empty unfurl messages for tracks and playlists (#9795) Kyle Shanks [2faf2e0] Add CHAT routes to static_routes (#9796) Reed [8b28228] [C-4969] Comment tombstones (#9790) JD Francis [e613a0b] [PAY-3215] ChatBlastCTA in own followers and supporters screens (#9793) Andrew Mendelsohn [123403b] [PAY-3211] Chat blast audience display (mobile) (#9792) Andrew Mendelsohn [d93fcab] [PAY-3210, PAY-3346] Chat blast audience tile (web) (#9778) Andrew Mendelsohn [32f758d] [QA-1730] Add sort back to the search query (#9787) Kyle Shanks [2359e1a] Chat fix quicktype (#9782) Steve Perkins [9be9c3a] [PAY-3209] Chat blast mobile header (#9777) Reed [9f05224] Use Harmony Artwork for ChatBlastHeader (#9785) Reed [2d838c5] [C-5024] Add comment notification (#9781) Dylan Jeffers [a6850d4] Handle dupe comment thread indexing (#9574) Isaac Solo [c27a040] [C-4826] (web) Comment action confirmation modals & toasts (#9766) JD Francis [079cd5d] Remove direct only and add noQuote error (#9780) Raymond Jacobson [68c4084] Fix usdc-usdc purchase (#9779) Raymond Jacobson [839e1e8] Fix harmony tests (#9775) Sebastian Klingler [93c216b] [PAY-3367] Mobile chat blast audience/content selection (#9683) Reed [c6bb074] [PAY-3208] Web chat blast header (#9767) Reed [bfd9c38] Version Packages (#8915) github-actions[bot] [afc5416] [C-4970, C-4825] Add comment reports (#9680) Dylan Jeffers [f38fb31] Improve mobile profile spacing (#9758) Dylan Jeffers [74ed02a] Fix typecheck (#9768) Sebastian Klingler [38a5f29] [C-1601] Fix verified badge, Improve text-link (#9757) Dylan Jeffers [b6b0827] [C-5014] Remove search input auto-correct (#9756) Dylan Jeffers [d7c8a4c] [C-4973] Add edit comment e2e (#9679) Dylan Jeffers [5c839b9] Harmonize web challenge UI (#9762) Reed [94f614d] Fix composer input error and styling for DMs (#9765) Kyle Shanks [99fb10f] [C-4971] Add comment pin e2e (#9678) Dylan Jeffers [59c2d6e] [C-4988] Update mobile TrackScreen layout for remixes + comments (#9657) Sebastian Klingler [66b1b2c] [C-4943] Add comment sort (#9672) Dylan Jeffers [be35c44] Fixing lint from bad merge (#9764) Kyle Shanks [85be4f0] [QA-1326] Update challenge button labels to match spec (#9743) Reed [8e4f02b] [C-4871] Add timestamp highlighting for composer input (#9761) Kyle Shanks [0a67586] Add tab completion for compose UI autocomplete (#9682) Kyle Shanks [85b27c4] [C-5020] Search filter fixes for FilterButton (#9763) Sebastian Klingler [921f74d] Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754) Randy Schott [fc257e1] Fix challenge summary table (#9755) Reed [ab45d0e] [QA-1713] Add filter input to feature flag modal (#9740) Dylan Jeffers
3 participants
Description
Adds confirmation modals & success toasts to comment overflow menu actions
Also added a hook helper for managing status changes more easily
Pin
Flag & Hide
Mute User
Toggle Mute Notifs
Delete
NOTE: delete is unchanged and has no special toast (Despite having one in designs) because currently its not able to handle it since component gets unrendered. There are some options for changing this but I'm going to hold off on doing them because I want to discuss some of our optimistic update behavior with design tomorrow.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.