Skip to content

[C-4988] Update mobile TrackScreen layout for remixes + comments#9657

Merged
sliptype merged 13 commits intomainfrom
sk-mobile-remixes
Sep 16, 2024
Merged

[C-4988] Update mobile TrackScreen layout for remixes + comments#9657
sliptype merged 13 commits intomainfrom
sk-mobile-remixes

Conversation

@sliptype
Copy link
Contributor

@sliptype sliptype commented Sep 5, 2024

Description

NOTE: I didn't put this behind a feature flag because it's semi unrelated to comments. So this change will go live with next release

  • Show remix lineup on trackscreen when relevant
  • Delete TrackScreenRemixes
  • Refactor TrackScreen to use a top level VirtualizedScrollView instead of pushing everything into a single Lineup header
  • Delete TrackScreenMainContent, not really necessary anymore
  • Show cosign icon on lineup tiles and fix styling
  • Add itemsStyles to override padding of lineup items. We should think about removing the outer padding and delegating to the parent component
Screen.Recording.2024-09-05.at.4.57.52.PM.mov

How Has This Been Tested?

Tested:

  • Tracks without remixes
  • Tracks with remixes
  • Comments feature on/off
  • Tracks with a remix parent
  • Cosign in lineup and on track screen

Need to test:

  • Android

@sliptype sliptype requested review from a team, DejayJD and dylanjeffers September 5, 2024 22:03
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: 90ba433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian
Copy link

gitguardian bot commented Sep 5, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret 9858c5e core/infra/dev_config/discovery-one.docker.env View secret
11648676 Triggered Generic High Entropy Secret 9858c5e core/infra/dev_config/sandbox-one.env View secret
11648678 Triggered Generic High Entropy Secret 9858c5e core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret 9858c5e core/infra/dev_config/content-two.docker.env View secret
11648680 Triggered Generic High Entropy Secret 9858c5e core/infra/dev_config/content-one.docker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement, ui loooks much much nicer

return (
<View style={styles.item}>
<View
style={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think best to do [styles.item, itemStyles]

useEffect(() => {
if (track) {
dispatch(
remixesPageLineupActions.fetchLineupMetadatas(0, 10, false, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do this all unconditionally in trackScreen? i wonder if moving these into a Remixes block might be best?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good if you dont want to do a massive refactor rn though.

@sliptype sliptype enabled auto-merge (squash) September 16, 2024 19:25
@sliptype sliptype merged commit 59c2d6e into main Sep 16, 2024
@sliptype sliptype deleted the sk-mobile-remixes branch September 16, 2024 19:45
audius-infra pushed a commit that referenced this pull request Sep 21, 2024
[e28b82b] Add client support for single transaction reward claiming (#9801) Marcus Pasell
[1696b04] Version Packages (#9772) github-actions[bot]
[1c2edae] Reapply libs split (#9817) Sebastian Klingler
[c9f1142] [C-5026] Optimistic UI tweaks (web only for now) (#9816) JD Francis
[7c4b196] Don't show empty chat prompt for blasts (#9815) Reed
[7ef38cd] [QA-1732] Undo test code to fix unread pill check for notifications (#9814) Kyle Shanks
[ad274d8] [PAY-3214] Add CreateBlast CTA to followers and supporters user lists (web) (#9804) Andrew Mendelsohn
[3f862a8] UDF for chat_allowed (#9789) Steve Perkins
[fa1da71] revert max width on chats (#9806) Andrew Mendelsohn
[6074a68] [PAY-3216] Update upload share buttons (#9805) Andrew Mendelsohn
[b9a8c0b] Revert libs split (#9802) Sebastian Klingler
[8c80712] Fix merge issue (#9800) Sebastian Klingler
[0ea3a11] [QA-1731] Fix key filter label (#9798) Kyle Shanks
[bc28909] Separate libs from main sdk bundle (#9791) Sebastian Klingler
[4d8ad95] Add comment email and push (#9784) Dylan Jeffers
[734f766] [QA-1717] Fix empty unfurl messages for tracks and playlists (#9795) Kyle Shanks
[2faf2e0] Add CHAT routes to static_routes (#9796) Reed
[8b28228] [C-4969] Comment tombstones (#9790) JD Francis
[e613a0b] [PAY-3215] ChatBlastCTA in own followers and supporters screens (#9793) Andrew Mendelsohn
[123403b] [PAY-3211] Chat blast audience display (mobile) (#9792) Andrew Mendelsohn
[d93fcab] [PAY-3210, PAY-3346] Chat blast audience tile (web) (#9778) Andrew Mendelsohn
[32f758d] [QA-1730] Add sort back to the search query (#9787) Kyle Shanks
[2359e1a] Chat fix quicktype (#9782) Steve Perkins
[9be9c3a] [PAY-3209] Chat blast mobile header (#9777) Reed
[9f05224] Use Harmony Artwork for ChatBlastHeader (#9785) Reed
[2d838c5] [C-5024] Add comment notification (#9781) Dylan Jeffers
[a6850d4] Handle dupe comment thread indexing (#9574) Isaac Solo
[c27a040] [C-4826] (web) Comment action confirmation modals & toasts (#9766) JD Francis
[079cd5d] Remove direct only and add noQuote error (#9780) Raymond Jacobson
[68c4084] Fix usdc-usdc purchase (#9779) Raymond Jacobson
[839e1e8] Fix harmony tests (#9775) Sebastian Klingler
[93c216b] [PAY-3367] Mobile chat blast audience/content selection (#9683) Reed
[c6bb074] [PAY-3208] Web chat blast header (#9767) Reed
[bfd9c38] Version Packages (#8915) github-actions[bot]
[afc5416] [C-4970, C-4825] Add comment reports (#9680) Dylan Jeffers
[f38fb31] Improve mobile profile spacing (#9758) Dylan Jeffers
[74ed02a] Fix typecheck (#9768) Sebastian Klingler
[38a5f29] [C-1601] Fix verified badge, Improve text-link (#9757) Dylan Jeffers
[b6b0827] [C-5014] Remove search input auto-correct (#9756) Dylan Jeffers
[d7c8a4c] [C-4973] Add edit comment e2e (#9679) Dylan Jeffers
[5c839b9] Harmonize web challenge UI (#9762) Reed
[94f614d] Fix composer input error and styling for DMs (#9765) Kyle Shanks
[99fb10f] [C-4971] Add comment pin e2e (#9678) Dylan Jeffers
[59c2d6e] [C-4988] Update mobile TrackScreen layout for remixes + comments (#9657) Sebastian Klingler
[66b1b2c] [C-4943] Add comment sort (#9672) Dylan Jeffers
[be35c44] Fixing lint from bad merge (#9764) Kyle Shanks
[85be4f0] [QA-1326] Update challenge button labels to match spec (#9743) Reed
[8e4f02b] [C-4871] Add timestamp highlighting for composer input (#9761) Kyle Shanks
[0a67586] Add tab completion for compose UI autocomplete (#9682) Kyle Shanks
[85b27c4] [C-5020] Search filter fixes for FilterButton (#9763) Sebastian Klingler
[921f74d] Revert "[PAY-3388] Migrate feed to SDK (#9593)" (#9754) Randy Schott
[fc257e1] Fix challenge summary table (#9755) Reed
[ab45d0e] [QA-1713] Add filter input to feature flag modal (#9740) Dylan Jeffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants