Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] [CD] Add Aarch64 to cd#20288

Merged
szha merged 10 commits intoapache:v1.xfrom
mseth10:aarch64_cd
May 21, 2021
Merged

[v1.x] [CD] Add Aarch64 to cd#20288
szha merged 10 commits intoapache:v1.xfrom
mseth10:aarch64_cd

Conversation

@mseth10
Copy link
Contributor

@mseth10 mseth10 commented May 20, 2021

Description

This PR adds AArch64 support to MXNet CD pipeline.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

Following major changes are made as part of this PR:

  • Added u18 aarch64 nodes to Jenkins CI
  • Added restricted g4 node to be used for quantization tests in CD pipeline
  • Removed p3 nodes not being used anywhere
  • Added CD pipeline for aarch64
  • Added pypi doc file for aach64 wheel

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, unix-cpu, edge, sanity, centos-gpu, unix-gpu, clang, miscellaneous, website, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label May 20, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 20, 2021
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 21, 2021
szha
szha previously requested changes May 21, 2021
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manu for adding the arm binary distribution support! One concern I have is the choice to increase the number of pip packages for mxnet.

@szha szha dismissed their stale review May 21, 2021 18:12

no more concern

@szha szha merged commit 7530e0e into apache:v1.x May 21, 2021
@szha
Copy link
Member

szha commented May 21, 2021

Merged. Thanks @mseth10! Let's monitor the CD for a few days and make sure builds are smooth.

@Zha0q1
Copy link
Contributor

Zha0q1 commented May 21, 2021

thanks Manu!

waytrue17 pushed a commit to waytrue17/incubator-mxnet that referenced this pull request Jun 4, 2021
* add initial cd changes for aarch64

* skip failing aarch64 tests

* skip failing aarch64 tests

* add cd wheel support

* add aarch64 node to cd pypi

* fix dockerfile for aarch64

* fix dockerfile for aarch64

* refer github issue for failing tests

* update pypi package name

* add requirements file for aarch64 for cd docker
waytrue17 pushed a commit to waytrue17/incubator-mxnet that referenced this pull request Jun 4, 2021
* add initial cd changes for aarch64

* skip failing aarch64 tests

* skip failing aarch64 tests

* add cd wheel support

* add aarch64 node to cd pypi

* fix dockerfile for aarch64

* fix dockerfile for aarch64

* refer github issue for failing tests

* update pypi package name

* add requirements file for aarch64 for cd docker
mseth10 added a commit that referenced this pull request Jun 5, 2021
…20333)

* [v1.x] [CD] Add Aarch64 to cd (#20288)

* add initial cd changes for aarch64

* skip failing aarch64 tests

* skip failing aarch64 tests

* add cd wheel support

* add aarch64 node to cd pypi

* fix dockerfile for aarch64

* fix dockerfile for aarch64

* refer github issue for failing tests

* update pypi package name

* add requirements file for aarch64 for cd docker

* [v1.x] Enable MKLDNN + APL Integration in CD (#20294)

* initial

* Update python_images.sh

* Update python_images.sh

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update AARCH64_CPU_ADDITIONAL.md

* Update pip.md

* Update pip.md

* [v1.x] use gcc-8.5 instead of gcc-10 for aarch64 build (#20318)

* use gcc-8.5 instead of gcc-10 with outline-atomics flag

* debug openblas

* fix apt install

* use gcc-7 for openblas

* use gcc-8.4 for openblas

* update openblas

* remove gcc-8 as no longer required

* [v1.x] Update openblas version to 0.3.15 (#20328)

* update apl version

Co-authored-by: Manu Seth <22492939+mseth10@users.noreply.github.com>
Co-authored-by: Zhaoqi Zhu <zhaoqizhu96@gmail.com>
Co-authored-by: Wei Chu <weichu@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants