This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] use gcc-8.5 instead of gcc-10 for aarch64 build#20318
Merged
Zha0q1 merged 7 commits intoapache:v1.xfrom Jun 1, 2021
Merged
[v1.x] use gcc-8.5 instead of gcc-10 for aarch64 build#20318Zha0q1 merged 7 commits intoapache:v1.xfrom
Zha0q1 merged 7 commits intoapache:v1.xfrom
Conversation
|
Hey @mseth10 , Thanks for submitting the PR
CI supported jobs: [website, centos-gpu, centos-cpu, windows-gpu, miscellaneous, unix-gpu, windows-cpu, sanity, unix-cpu, edge, clang] Note: |
mseth10
added
the
pr-awaiting-testing
mseth10
requested review from
leezu
and removed request for
aaronmarkham and
marcoabreu
mseth10
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
Contributor
Author
|
@mxnet-bot run ci [centos-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu] |
mseth10
added
pr-awaiting-testing
Contributor
Author
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
the
pr-awaiting-testing
leezu
reviewed
May 28, 2021
tools/dependencies/openblas.sh
Outdated
Comment on lines
39
to
40
| # openblas build fails with gcc-8.5, hence using gcc-8.4 explicitly | ||
| CXX="g++-8 -fPIC" CC="gcc-8 -fPIC" FC="gfortran-8" $MAKE DYNAMIC_ARCH=1 USE_OPENMP=1 |
Contributor
There was a problem hiding this comment.
Have you tried updating openblas?
Contributor
Author
There was a problem hiding this comment.
Tried OpenBLAS v0.3.10 (same version as master) and it works with gcc-8.5 , updated it. Thanks for the suggestion.
Contributor
There was a problem hiding this comment.
Great! Would you consider v0.3.15? I see there are a couple of ARM-specific fixes in between of v0.3.10 and v0.3.15 including "Fixed segmentation faults in DYNAMIC_ARCH builds" which would affect us as we use DYNAMIC_ARCH=1
mseth10
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
mseth10
added
pr-work-in-progress
Contributor
|
Merging this pr for now so I can base the APL changes to this commit. We can update openblas in another pr |
6 tasks
waytrue17
pushed a commit
to waytrue17/incubator-mxnet
that referenced
this pull request
Jun 4, 2021
* use gcc-8.5 instead of gcc-10 with outline-atomics flag * debug openblas * fix apt install * use gcc-7 for openblas * use gcc-8.4 for openblas * update openblas * remove gcc-8 as no longer required
waytrue17
pushed a commit
to waytrue17/incubator-mxnet
that referenced
this pull request
Jun 4, 2021
* use gcc-8.5 instead of gcc-10 with outline-atomics flag * debug openblas * fix apt install * use gcc-7 for openblas * use gcc-8.4 for openblas * update openblas * remove gcc-8 as no longer required
mseth10
added a commit
that referenced
this pull request
Jun 5, 2021
…20333) * [v1.x] [CD] Add Aarch64 to cd (#20288) * add initial cd changes for aarch64 * skip failing aarch64 tests * skip failing aarch64 tests * add cd wheel support * add aarch64 node to cd pypi * fix dockerfile for aarch64 * fix dockerfile for aarch64 * refer github issue for failing tests * update pypi package name * add requirements file for aarch64 for cd docker * [v1.x] Enable MKLDNN + APL Integration in CD (#20294) * initial * Update python_images.sh * Update python_images.sh * Update Dockerfile * Update Dockerfile * Update Dockerfile * Update AARCH64_CPU_ADDITIONAL.md * Update pip.md * Update pip.md * [v1.x] use gcc-8.5 instead of gcc-10 for aarch64 build (#20318) * use gcc-8.5 instead of gcc-10 with outline-atomics flag * debug openblas * fix apt install * use gcc-7 for openblas * use gcc-8.4 for openblas * update openblas * remove gcc-8 as no longer required * [v1.x] Update openblas version to 0.3.15 (#20328) * update apl version Co-authored-by: Manu Seth <22492939+mseth10@users.noreply.github.com> Co-authored-by: Zhaoqi Zhu <zhaoqizhu96@gmail.com> Co-authored-by: Wei Chu <weichu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to get the advantage of LSE support while supporting all AArch64 platforms, we used gcc-10 on u18 base docker image as it supports the build flag
-moutline-atomics. But using gcc-10 also creates a dependency of generated MXNet wheel on GLIBCXX_3.4.26, and so we need to upgrade libstdc++6 package on u18 to get the wheel working. On u20, the wheel works fine.2 weeks ago gcc-8.5 was launched that added support for the build flag
-moutline-atomics. Since there is no ubuntu/canonical package for gcc-8.5, I tried building it from source and it works, with the advantage over gcc-10 that we dont need to upgrade libstdc++6 on u18.Changes
libc6-lse.-march=armv8-a+crc+cryptoinstead of-march=armv8earlier to get the benefit of crc and crypto extension.