Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Enable MKLDNN + APL Integration in CD#20294

Merged
Zha0q1 merged 9 commits intoapache:v1.xfrom
Zha0q1:arm_enable_apl_in_cd
May 26, 2021
Merged

[v1.x] Enable MKLDNN + APL Integration in CD#20294
Zha0q1 merged 9 commits intoapache:v1.xfrom
Zha0q1:arm_enable_apl_in_cd

Conversation

@Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented May 21, 2021 •
edited
Loading

Enable MKLDNN integration with APL by defualt and fix cd docker image pipelines

@mxnet-bot
Copy link

mxnet-bot commented May 21, 2021

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, edge, windows-gpu, centos-cpu, centos-gpu, miscellaneous, unix-gpu, website, sanity, clang, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 21, 2021
@Zha0q1 Zha0q1 changed the title [wip] [v1.x] Enable MKLDNN + APL Integration in CD [v1.x] Enable MKLDNN + APL Integration in CD May 24, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 24, 2021
@Zha0q1 Zha0q1 requested a review from szha as a code owner May 24, 2021 22:55
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 24, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 25, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label May 25, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels May 25, 2021
mseth10
mseth10 reviewed May 25, 2021
View reviewed changes
josephevans
josephevans approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mseth10
Copy link
Contributor

mseth10 commented May 25, 2021

Hey @Zha0q1 , do we need to add any licenses related to ArmPL?

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented May 25, 2021

Hey @Zha0q1 , do we need to add any licenses related to ArmPL?

ArmPL's license is not Apache compatible. That's why we don't include it in the wheel. We need to require users to install ArmPL in their environment. Do you want me to modify the "getting started" doc in this pr? Alternatively I can also create another pr to update the doc

@mseth10
Copy link
Contributor

mseth10 commented May 25, 2021

Hey @Zha0q1 , do we need to add any licenses related to ArmPL?

ArmPL's license is not Apache compatible. That's why we don't include it in the wheel. We need to require users to install ArmPL in their environment. Do you want me to modify the "getting started" doc in this pr? Alternatively I can also create another pr to update the doc

yeah we need to have these instructions in the install doc, can you please update it? a new PR is also fine..

mseth10
mseth10 approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 25, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels May 25, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 26, 2021
@Zha0q1 Zha0q1 merged commit cc49972 into apache:v1.x May 26, 2021
waytrue17 pushed a commit to waytrue17/incubator-mxnet that referenced this pull request Jun 4, 2021
@Zha0q1
[v1.x] Enable MKLDNN + APL Integration in CD (apache#20294)
7666439 
* initial

* Update python_images.sh

* Update python_images.sh

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update AARCH64_CPU_ADDITIONAL.md

* Update pip.md

* Update pip.md
waytrue17 pushed a commit to waytrue17/incubator-mxnet that referenced this pull request Jun 4, 2021
@Zha0q1
[v1.x] Enable MKLDNN + APL Integration in CD (apache#20294)
bdcddfa 
* initial

* Update python_images.sh

* Update python_images.sh

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update AARCH64_CPU_ADDITIONAL.md

* Update pip.md

* Update pip.md
mseth10 added a commit that referenced this pull request Jun 5, 2021
@waytrue17 @mseth10 @Zha0q1
[v1.9.x] aarch64 build using gcc8.5 + APL integration + CD pipeline (#…
7e3bd45 
…20333)

* [v1.x] [CD] Add Aarch64 to cd (#20288)

* add initial cd changes for aarch64

* skip failing aarch64 tests

* skip failing aarch64 tests

* add cd wheel support

* add aarch64 node to cd pypi

* fix dockerfile for aarch64

* fix dockerfile for aarch64

* refer github issue for failing tests

* update pypi package name

* add requirements file for aarch64 for cd docker

* [v1.x] Enable MKLDNN + APL Integration in CD (#20294)

* initial

* Update python_images.sh

* Update python_images.sh

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update AARCH64_CPU_ADDITIONAL.md

* Update pip.md

* Update pip.md

* [v1.x] use gcc-8.5 instead of gcc-10 for aarch64 build (#20318)

* use gcc-8.5 instead of gcc-10 with outline-atomics flag

* debug openblas

* fix apt install

* use gcc-7 for openblas

* use gcc-8.4 for openblas

* update openblas

* remove gcc-8 as no longer required

* [v1.x] Update openblas version to 0.3.15 (#20328)

* update apl version

Co-authored-by: Manu Seth <22492939+mseth10@users.noreply.github.com>
Co-authored-by: Zhaoqi Zhu <zhaoqizhu96@gmail.com>
Co-authored-by: Wei Chu <weichu@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@josephevans josephevans josephevans approved these changes

@mseth10 mseth10 mseth10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zha0q1 @mxnet-bot @mseth10 @josephevans