Rollup of 8 pull requests #151291

jhpratt · 2026-01-18T08:16:48Z

Successful merges:

Stabilize alloc_layout_extra #148769 (Stabilize alloc_layout_extra)
Add title field to ice.md issue template #150200 (Add title field to ice.md issue template)
Underscore-prefixed bindings are explicitly allowed to be unused #150955 (Underscore-prefixed bindings are explicitly allowed to be unused)
time: Add saturating arithmetic for SystemTime #151200 (time: Add saturating arithmetic for SystemTime)
Change field bit_width: usize to bits: u32 in type info #151235 (Change field bit_width: usize to bits: u32 in type info)
Port #[needs_allocator] to attribute parser #151242 (Port #[needs_allocator] to attribute parser)
Include a link to count_ones in the docs for uN::count_zeros [docs only] #151274 (Include a link to count_ones in the docs for uN::count_zeros [docs only])
remove trailing periods in built-in attribute gate messages #151279 (remove trailing periods in built-in attribute gate messages)

This commit implements the following methods: * `SystemTime::saturating_add` * `SystemTime::saturating_sub` * `SystemTime::saturating_duration_since` The implementation of these methods is rather trivial, as the main logic lies behind the constants `SystemTime::MIN` and `SystemTime::MAX`.

…ottmcm Stabilize `alloc_layout_extra` Tracking issue: rust-lang#55724 FCP completed in rust-lang#55724 (comment) Closes rust-lang#55724 ---- As per rust-lang#55724 (comment), - `repeat_packed` and `extend_packed` are unchanged - `repeat` now excludes trailing padding on the last element from the total array size - `dangling` renamed to `dangling_ptr` - `padding_needed_for` not stabilized, changed to accept `Alignment` instead of `usize` and moved to the `ptr_aligment_type` feature flag (tracking issue: rust-lang#102070)

Add title field to `ice.md` issue template The `ice.yml` template has [a title field](https://github.com/rust-lang/rust/blob/d0835adc4e114eac911150b3692b830b5583223a/.github/ISSUE_TEMPLATE/ice.yaml?plain=1#L4), but the `ice.md` template doesn't.

…=fee1-dead Underscore-prefixed bindings are explicitly allowed to be unused Fixes rust-lang#149889

…-Simulacrum time: Add saturating arithmetic for `SystemTime` This commit implements the following methods: * `SystemTime::saturating_add` * `SystemTime::saturating_sub` * `SystemTime::saturating_duration_since` The implementation of these methods is rather trivial, as the main logic lies behind the constants `SystemTime::MIN` and `SystemTime::MAX`. See also: * Accepted ACP: rust-lang/libs-team#718 * Tracking Issue: rust-lang#151199

@Skgland

Change field `bit_width: usize` to `bits: u32` in type info Follow-up rust-lang#151123 (comment). Quotes: @Skgland: > > I'm not sure whether we should use `usize` or `u64` here to represent the bit width. > > My expectation would be `u32` matching the associated `{u,i}N::BITS`[^1][^2][^3] constant that already exists on the integer types. > > [^1]: https://doc.rust-lang.org/std/primitive.i8.html#associatedconstant.BITS > [^2]: https://doc.rust-lang.org/std/primitive.i128.html#associatedconstant.BITS > [^3]: https://doc.rust-lang.org/std/primitive.usize.html#associatedconstant.BITS @SpriteOvO: > I found some [previous discussions](rust-lang#76492 (comment)) regarding the type of `::BITS` constant. And during the stabilization of `::BITS`, the choice of `u32` affected some ecosystem crates (rust-lang#81654), but soon after, these crates all accepted the `u32` type. > > So I think it makes sense to keep the type consistent with `::BITS` here. Then I'd also like to change the name from `bit_width` to `bits`, also for consistency. r? @oli-obk

Port #[needs_allocator] to attribute parser Tracking issue: rust-lang#131229 Ports needs_allocator attribute to the new attribute parser. Note: this is a deprecated and feature gated attribute.

Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only] I did not update `iN` because `count_zeros` is reasonable for *negative* numbers. Rendered: <img width="1188" height="524" alt="image" src="https://github.com/user-attachments/assets/80ebf53c-3cde-4230-b436-d2148b07d4c8" /> <img width="1186" height="517" alt="image" src="https://github.com/user-attachments/assets/544d2ff4-ee35-44f7-8d50-65fc5f0ff3c9" />

remove trailing periods in built-in attribute gate messages consistency, we do this for all diagnostic texts

jhpratt · 2026-01-18T08:16:55Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-18T08:16:58Z

📌 Commit 5fd13b5 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-01-18T14:49:39Z

☀️ Test successful - CI
Approved by: jhpratt
Pushing ba2a7d3 to main...

rust-timer · 2026-01-18T14:51:54Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#148769	Stabilize `alloc_layout_extra`	`a1d396231257d996a477e718ca0a4f4b5de351d0` (link)
#150200	Add title field to `ice.md` issue template	`08d9f54c6dd1e0ee2411128737a6193c02ffc618` (link)
#150955	Underscore-prefixed bindings are explicitly allowed to be u…	`a4ae3ddfe16110cc03a6de009b7fc811a209d6aa` (link)
#151200	time: Add saturating arithmetic for `SystemTime`	`bc5fd18449d651a1d8b95540780e280bc293eb02` (link)
#151235	Change field `bit_width: usize` to `bits: u32` in type info	`1f14b9a49e5c18ef455733bb980c2552f0b08f80` (link)
#151242	Port #[needs_allocator] to attribute parser	`c8dd1fd9d9999a663ed14008f0fa209cf21b988e` (link)
#151274	Include a link to `count_ones` in the docs for `uN::count_z…	`b7d2fa493ecf55daa613be7d4ed47486b22f7693` (link)
#151279	remove trailing periods in built-in attribute gate messages	`59351542e898522f30d9f09a004ef3ecb6d48896` (link)

previous master: 621d76794c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-18T14:52:22Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 621d767 (parent) -> ba2a7d3 (this PR)

Test differences

Show 3553 test diffs

Stage 1

system_time_saturating: [missing] -> pass (J2)
[ui] tests/ui/lint/unused/underscore-capture-issue-149889.rs: [missing] -> pass (J4)

Stage 2

system_time_saturating: [missing] -> pass (J0)
[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J1)
[ui] tests/ui/lint/unused/underscore-capture-issue-149889.rs: [missing] -> pass (J3)

Additionally, 3548 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ba2a7d33741a7ade4dc78e5e335d60d358cd1749 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 8874.7s -> 11042.3s (+24.4%)
pr-check-1: 2341.2s -> 1956.3s (-16.4%)
i686-gnu-2: 5290.7s -> 6149.5s (+16.2%)
i686-gnu-1: 7599.8s -> 8830.3s (+16.2%)
tidy: 152.6s -> 176.8s (+15.9%)
x86_64-gnu-llvm-20-3: 6118.5s -> 7068.6s (+15.5%)
test-various: 8106.2s -> 6924.3s (-14.6%)
x86_64-gnu-tools: 4332.4s -> 3706.8s (-14.4%)
x86_64-rust-for-linux: 3671.7s -> 3150.8s (-14.2%)
i686-gnu-nopt-1: 7449.7s -> 8432.6s (+13.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-18T15:31:26Z

Finished benchmarking commit (ba2a7d3): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.6%]	17
Regressions ❌ (secondary)	0.5%	[0.1%, 1.7%]	41
Improvements ✅ (primary)	-0.8%	[-2.3%, -0.2%]	4
Improvements ✅ (secondary)	-0.4%	[-2.1%, -0.2%]	11
All ❌✅ (primary)	0.0%	[-2.3%, 0.6%]	21

Max RSS (memory usage)

Results (primary 3.4%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	6.3%	[0.9%, 11.7%]	2
Regressions ❌ (secondary)	2.8%	[2.0%, 3.6%]	2
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.4%	[-2.3%, 11.7%]	3

Cycles

Results (primary -2.1%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-2.3%	[-2.7%, -1.8%]	3
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Binary size

Results (primary 0.1%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 0.8%]	14
Regressions ❌ (secondary)	0.4%	[0.0%, 0.7%]	8
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	15
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	3
All ❌✅ (primary)	0.1%	[-0.2%, 0.8%]	29

Bootstrap: 474.856s -> 473.711s (-0.24%)
Artifact size: 383.43 MiB -> 383.20 MiB (-0.06%)

reddevilmidzy and others added 16 commits December 21, 2025 00:26

Add title field to ICE issue template

7b7ee84

Underscore-prefixed bindings are explicitly allowed to be unused

ea93fb5

Stabilize alloc_layout_extra

e212560

Change field bit_width: usize to bits: u32 in type info

27b0279

Port #[needs_allocator] to attribute parser

ebfd227

Include a link to count_ones in the docs for uN::count_zeros

b49539e

remove trailing periods in built-in attribute gate messages

216ca14

Rollup merge of rust-lang#150955 - yukang-fix-149889-unused-assign, r…

0331284

…=fee1-dead Underscore-prefixed bindings are explicitly allowed to be unused Fixes rust-lang#149889

Rollup merge of rust-lang#151242 - master, r=JonathanBrouwer

845316c

Port #[needs_allocator] to attribute parser Tracking issue: rust-lang#131229 Ports needs_allocator attribute to the new attribute parser. Note: this is a deprecated and feature gated attribute.

Rollup merge of rust-lang#151279 - push-xzxlnsyqtuoo, r=chenyukang

5fd13b5

remove trailing periods in built-in attribute gate messages consistency, we do this for all diagnostic texts

rust-bors bot added the rollup A PR which is a rollup label Jan 18, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 18, 2026

rust-bors bot merged commit ba2a7d3 into rust-lang:main Jan 18, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 18, 2026

This was referenced Jan 18, 2026

constify Iterator, take IV #151281

Open

Make Rc<T>::deref and Arc<T>::deref zero-cost #132553

Open

Make Rc<T>::deref zero-cost #141348

Open

add FCW to invalid #[should_panic] and #[ignore] #150416

Open

jhpratt deleted the rollup-CVsL9ZN branch January 18, 2026 15:21

rustbot added the perf-regression Performance regression. label Jan 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 8 pull requests #151291

Rollup of 8 pull requests #151291

jhpratt commented Jan 18, 2026

Uh oh!

jhpratt commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 18, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Rollup of 8 pull requests #151291

Rollup of 8 pull requests #151291

Conversation

jhpratt commented Jan 18, 2026

Uh oh!

jhpratt commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 18, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 18, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants