Skip to content

fix: ensure ENV_PREFIX.length works#16106

Merged
Rich-Harris merged 2 commits into
mainfrom
fix-node-env-prefix
Jun 22, 2026
Merged

fix: ensure ENV_PREFIX.length works#16106
Rich-Harris merged 2 commits into
mainfrom
fix-node-env-prefix

Conversation

@teemingc

@teemingc teemingc commented Jun 20, 2026

Copy link
Copy Markdown
Member

closes #16090
closes #16096

This PR is an alternative to #16096 that reuses an existing pattern of storing the inlined variable in a constant and reusing that throughout the code. The added benefit is that we reduce the number of times the string literal appears in the build output.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 32173e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Rich-Harris Rich-Harris merged commit ea309d4 into main Jun 22, 2026
27 checks passed
@Rich-Harris Rich-Harris deleted the fix-node-env-prefix branch June 22, 2026 16:56
@github-actions github-actions Bot mentioned this pull request Jun 22, 2026
Rich-Harris pushed a commit that referenced this pull request Jun 22, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.67.0

### Minor Changes


- feat: add `prerender.handleInvalidUrl` option for invalid URLs
discovered while crawling
([#16088](#16088))


### Patch Changes


- fix: support `exactOptionalPropertyTypes` for optional form schema
fields ([#15866](#15866))


- fix: avoid unnecessarily overriding a user's Vite 8 `codeSplitting`
setting ([#16118](#16118))
## @sveltejs/adapter-node@5.5.6

### Patch Changes


- fix: avoid circular dependency between server initialisation and hook
retrieval that causes the app to crash on start
([#16115](#16115))


- fix: correctly resolve root directory on the server
([#16114](#16114))


- fix: ensure `ENV_PREFIX` is defined
([#16106](#16106))

- Updated dependencies
[[`cf15fa0`](cf15fa0),
[`5c76121`](5c76121),
[`2992e17`](2992e17)]:
  - @sveltejs/kit@2.67.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENV_PREFIX not consistently replaced in adapter-node@5.5.5 builds

2 participants