fix: avoid circular dependency#16115
Conversation
🦋 Changeset detectedLatest commit: 1059591 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This reverts commit 0cdf147.
| handler: 'src/handler.js', | ||
| shims: 'src/shims.js' | ||
| shims: 'src/shims.js', | ||
| utils: 'utils.js' |
There was a problem hiding this comment.
I know it's not specific to this PR but why is this in the root? Feels like it should be src/utils.js no?
There was a problem hiding this comment.
Yeah, it think it was misplaced. It's not imported by any files outside src
| if (id.startsWith(server)) { | ||
| return id.slice(server_path_length); | ||
| } | ||
|
|
||
| if (entry_files.includes(id)) { | ||
| return id.slice(build_directory.length); | ||
| } |
There was a problem hiding this comment.
Do we need both of these? It basically prevents any bundling from occurring, which presumably will negatively impact startup time. If we get rid of the first and just keep the second, does the bug still occur? (I don't have a local repro at the moment)
There was a problem hiding this comment.
I tested and the first one is crucial to prevent the circular dep. The second one can be removed
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.67.0 ### Minor Changes - feat: add `prerender.handleInvalidUrl` option for invalid URLs discovered while crawling ([#16088](#16088)) ### Patch Changes - fix: support `exactOptionalPropertyTypes` for optional form schema fields ([#15866](#15866)) - fix: avoid unnecessarily overriding a user's Vite 8 `codeSplitting` setting ([#16118](#16118)) ## @sveltejs/adapter-node@5.5.6 ### Patch Changes - fix: avoid circular dependency between server initialisation and hook retrieval that causes the app to crash on start ([#16115](#16115)) - fix: correctly resolve root directory on the server ([#16114](#16114)) - fix: ensure `ENV_PREFIX` is defined ([#16106](#16106)) - Updated dependencies [[`cf15fa0`](cf15fa0), [`5c76121`](5c76121), [`2992e17`](2992e17)]: - @sveltejs/kit@2.67.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
closes #16092
This PR tries to keep the benefits of #16069 while ensuring the Node adapter handler code and the user's server build output are in separate chunks. Doing so avoids the circular dependency that causes the app to crash on startup.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits