Skip to content

fix: ensure server root directory is resolved correctly#16114

Merged
Rich-Harris merged 4 commits into
mainfrom
fix-node-assets-path
Jun 22, 2026
Merged

fix: ensure server root directory is resolved correctly#16114
Rich-Harris merged 4 commits into
mainfrom
fix-node-assets-path

Conversation

@teemingc

@teemingc teemingc commented Jun 22, 2026

Copy link
Copy Markdown
Member

closes #16095

This PR adds a Rollup plugin to correct module relative paths. It worked previously because the import.meta.url code was called from a file at the root. However, bundling the entries caused Rollup to move it to a shared chunk which lived in a nested directory. The new plugin ensures that entries creating a relative URL resolves correctly to the root


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d5d0ae8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Rich-Harris Rich-Harris merged commit 6261b50 into main Jun 22, 2026
65 of 67 checks passed
@Rich-Harris Rich-Harris deleted the fix-node-assets-path branch June 22, 2026 17:03
@github-actions github-actions Bot mentioned this pull request Jun 22, 2026
@Rich-Harris

Copy link
Copy Markdown
Member

For posterity: this ended up not working (we need to find the path relative to the output chunkId not the input moduleId) so I replaced it with a simpler fix in #16104 — just put the import.meta.url in an entrypoint that will be directly inside the output directory

Rich-Harris pushed a commit that referenced this pull request Jun 22, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.67.0

### Minor Changes


- feat: add `prerender.handleInvalidUrl` option for invalid URLs
discovered while crawling
([#16088](#16088))


### Patch Changes


- fix: support `exactOptionalPropertyTypes` for optional form schema
fields ([#15866](#15866))


- fix: avoid unnecessarily overriding a user's Vite 8 `codeSplitting`
setting ([#16118](#16118))
## @sveltejs/adapter-node@5.5.6

### Patch Changes


- fix: avoid circular dependency between server initialisation and hook
retrieval that causes the app to crash on start
([#16115](#16115))


- fix: correctly resolve root directory on the server
([#16114](#16114))


- fix: ensure `ENV_PREFIX` is defined
([#16106](#16106))

- Updated dependencies
[[`cf15fa0`](cf15fa0),
[`5c76121`](5c76121),
[`2992e17`](2992e17)]:
  - @sveltejs/kit@2.67.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adapter-node@5.5.5: node build returns 404 for all /_app/* and static client assets (broken import.meta.url asset dir from #16069)

2 participants