Skip to content

fix(slotProps): add missed input types#9444

Merged
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/fix/slotProps
Feb 4, 2026
Merged

fix(slotProps): add missed input types#9444
inomdzhon merged 1 commit intomasterfrom
imirdzhamolov/fix/slotProps

Conversation

@inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon self-assigned this Feb 4, 2026
@inomdzhon inomdzhon requested a review from a team as a code owner February 4, 2026 14:32
@inomdzhon inomdzhon added this to VKUI Feb 4, 2026
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 4, 2026
@inomdzhon inomdzhon added cmp:checkbox and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Feb 4, 2026
@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Feb 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

size-limit report 📦

Path Size
JS 411.77 KB (+0.13% 🔺)
JS (gzip) 126.31 KB (+0.11% 🔺)
JS (brotli) 104.29 KB (+0.04% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 373.62 KB (0%)
CSS (gzip) 46.29 KB (0%)
CSS (brotli) 36.54 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 655e923

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9444/655e92307b518565d373c67d8793e302aa3723fd/pkg/@vkontakte/vkui/_pkg.tgz

Commit 655e923

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (56abd37) to head (655e923).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9444   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         440      440           
  Lines       11891    11891           
  Branches     4387     4387           
=======================================
  Hits        11271    11271           
  Misses        620      620           
Flag Coverage Δ
unittests 94.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

e2e tests

Playwright Report

@inomdzhon inomdzhon merged commit 0d467c7 into master Feb 4, 2026
51 of 53 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/slotProps branch February 4, 2026 15:09
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Feb 4, 2026
inomdzhon added a commit that referenced this pull request Feb 4, 2026
…rops (#9445)

Обновляем кодмод для VKUI v8 по мотивам #9444.

Пополняем `moveInputPropsIntoSlotProps` событиями:
- `onInput`
- `onInputCapture`
- `onClick`
- `onClickCapture`
- `onPaste`
- `onPasteCapture`
- `onKeyDown`
- `onKeyDownCapture`
- `onKeyUp`
- `onKeyUpCapture`

пользователи могут завязываться на `event.currentTarget`, а это теперь корневой элемент, зачастую `<div>`. Если даже не завязываются, то могу упасть типы – например, `<Input onPaste={(event: React.SyntheticEvent<HTMLInputElement>) => void 0} />` выдаст ошибку типов (см. скрин ниже):

<img width="320" height="367" alt="image" src="https://github.com/user-attachments/assets/cb7b142a-dfc8-4027-8b1f-de011a00adc1" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants