[refactor](field) Use Field to replace StringRef#60253
Merged
Gabriel39 merged 7 commits intoapache:masterfrom Feb 3, 2026
Merged
[refactor](field) Use Field to replace StringRef#60253Gabriel39 merged 7 commits intoapache:masterfrom
Gabriel39 merged 7 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 0 ms |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 31615 ms |
ClickBench: Total hot run time: 28.99 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 5439 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32363 ms |
ClickBench: Total hot run time: 28.7 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
reviewed
Jan 29, 2026
be/src/olap/comparison_predicate.h
Outdated
Contributor
There was a problem hiding this comment.
why not use string to compare？
Contributor
There was a problem hiding this comment.
感觉这里我们predicate 里存储的是std string，然后wrapper field 里也是string，我们似乎在把这俩都cast 成stringref 来搞
Contributor
Author
|
run buildall |
yiguolei
reviewed
Feb 2, 2026
| }; | ||
|
|
||
| template <> | ||
| struct type_limit<std::string> { |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 5289 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 31191 ms |
ClickBench: Total hot run time: 28.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 31680 ms |
ClickBench: Total hot run time: 29.26 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31563 ms |
ClickBench: Total hot run time: 28.09 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Feb 3, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
zhangstar333
approved these changes
Feb 3, 2026
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Feb 6, 2026
yiguolei
pushed a commit
that referenced
this pull request
Feb 7, 2026
### What problem does this PR solve? Pick #60253 #60393 #60481 #56956 #60334 #60494 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)