[refactor](predicate) Refactor zone map#60393
Merged
Gabriel39 merged 3 commits intoapache:masterfrom Feb 4, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
3 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190386 ms |
Gabriel39
force-pushed
the
refactor_0130
branch
from
80331a6 to
31cb346
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31900 ms |
ClickBench: Total hot run time: 28.29 s |
Contributor
Author
|
run buildall |
Gabriel39
force-pushed
the
refactor_0130
branch
from
c704804 to
35386e2
Compare
Gabriel39
force-pushed
the
refactor_0130
branch
from
35386e2 to
46f5983
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31862 ms |
ClickBench: Total hot run time: 28.44 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32392 ms |
ClickBench: Total hot run time: 28.28 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32255 ms |
ClickBench: Total hot run time: 28.26 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
reviewed
Feb 4, 2026
| return Status::OK(); | ||
| } | ||
|
|
||
| Status ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB& zone_map, |
Contributor
There was a problem hiding this comment.
如果我们zone_map_info 能表达出来all null，has null，not null 之类的，这个函数感觉没用了啊
| if (type == FieldType::OLAP_FIELD_TYPE_CHAR) { | ||
| auto s = zone_map_info.max_value.template get<TYPE_CHAR>(); | ||
| while (!s.empty() && s.back() == '\0') { | ||
| s.pop_back(); |
Contributor
There was a problem hiding this comment.
我们这里为什么要把char 类型的padding 去掉？
| RETURN_IF_ERROR(_parse_zone_map(zone_maps[i], min_value.get(), max_value.get())); | ||
| if (_zone_map_match_condition(zone_maps[i], min_value.get(), max_value.get(), | ||
| col_predicates)) { | ||
| RETURN_IF_ERROR(_parse_zone_map(zone_maps[i], zone_map_info)); |
Contributor
There was a problem hiding this comment.
把614 行移动到616，防止重复使用，结果一些变量没有reset
yiguolei
approved these changes
Feb 4, 2026
zhangstar333
approved these changes
Feb 4, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
jacktengg
reviewed
Feb 5, 2026
|
|
||
| auto arg_precision = static_cast<UInt32>(precision); | ||
|
|
||
| if (!CastToDecimal::from_string(StringRef(str), to, arg_precision, 0, params)) { |
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Feb 6, 2026
yiguolei
pushed a commit
that referenced
this pull request
Feb 7, 2026
### What problem does this PR solve? Pick #60253 #60393 #60481 #56956 #60334 #60494 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)