Skip to content

[fix](test) Remove wrapper_field dependency from unit tests#60530

Merged
yiguolei merged 10 commits intoapache:masterfrom
Gabriel39:refactor_0205
Feb 7, 2026
Merged

[fix](test) Remove wrapper_field dependency from unit tests#60530
yiguolei merged 10 commits intoapache:masterfrom
Gabriel39:refactor_0205

Conversation

@Gabriel39
Copy link
Contributor

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove dependency on the deleted wrapper_field.h header. Replace WrapperField usage with hardcoded min/max values for IP addresses and direct string comparisons for other types. Test logic and coverage are preserved.

  • Remove wrapper_field.h includes
  • Replace WrapperField::create_by_type() and related calls with explicit values
  • Update test data structures to remove wrapper field expectations
  • Simplify nullable string tests to use test string directly
  • Update comments to reflect serde-only testing approach

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove
dependency on the deleted wrapper_field.h header. Replace WrapperField
usage with hardcoded min/max values for IP addresses and direct string
comparisons for other types. Test logic and coverage are preserved.

- Remove wrapper_field.h includes
- Replace WrapperField::create_by_type() and related calls with explicit values
- Update test data structures to remove wrapper field expectations
- Simplify nullable string tests to use test string directly
- Update comments to reflect serde-only testing approach

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31324 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa4318de3192a43d3efbce60f25bf04226134e20, data reload: false

------ Round 1 ----------------------------------
q1	17674	4497	4315	4315
q2	2050	398	230	230
q3	10087	1331	768	768
q4	10205	812	329	329
q5	7520	2214	1911	1911
q6	217	185	146	146
q7	889	738	581	581
q8	9272	1465	1135	1135
q9	5673	4898	4818	4818
q10	6872	1956	1557	1557
q11	510	293	292	292
q12	403	373	224	224
q13	17787	4118	3265	3265
q14	232	231	213	213
q15	900	839	800	800
q16	688	670	622	622
q17	647	759	533	533
q18	7412	6720	6637	6637
q19	1460	1010	623	623
q20	376	350	238	238
q21	2723	2132	1813	1813
q22	362	322	274	274
Total cold run time: 103959 ms
Total hot run time: 31324 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4414	4329	4352	4329
q2	268	329	248	248
q3	2126	2616	2274	2274
q4	1347	1720	1288	1288
q5	4267	4168	4268	4168
q6	218	183	139	139
q7	1829	1808	2177	1808
q8	2637	2512	2526	2512
q9	7533	7549	7566	7549
q10	2949	2995	2605	2605
q11	555	468	454	454
q12	675	820	587	587
q13	3921	4509	3561	3561
q14	297	301	292	292
q15	855	835	824	824
q16	670	767	833	767
q17	1164	1379	1348	1348
q18	8111	8091	8048	8048
q19	931	882	854	854
q20	2084	2113	1986	1986
q21	4724	4517	4390	4390
q22	613	583	508	508
Total cold run time: 52188 ms
Total hot run time: 50539 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fa4318de3192a43d3efbce60f25bf04226134e20, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.04	0.04
query3	0.25	0.09	0.09
query4	1.61	0.12	0.11
query5	0.28	0.26	0.25
query6	1.18	0.69	0.68
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.57	0.50	0.50
query10	0.56	0.54	0.55
query11	0.15	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.63	0.62
query14	1.06	1.06	1.08
query15	0.88	0.86	0.86
query16	0.44	0.39	0.39
query17	1.12	1.11	1.15
query18	0.22	0.22	0.21
query19	2.12	2.00	2.02
query20	0.02	0.02	0.01
query21	15.41	0.25	0.15
query22	5.00	0.06	0.05
query23	15.71	0.29	0.11
query24	1.16	0.38	0.19
query25	0.10	0.08	0.06
query26	0.15	0.13	0.13
query27	0.08	0.09	0.05
query28	3.47	1.15	0.96
query29	12.58	3.88	3.14
query30	0.28	0.14	0.12
query31	2.82	0.64	0.40
query32	3.24	0.60	0.51
query33	3.31	3.30	3.22
query34	16.48	5.38	4.73
query35	4.82	4.84	4.75
query36	0.66	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.20	0.16	0.16
query41	0.09	0.04	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.33 s
Total hot run time: 28.21 s

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31351 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e5a5c16e841cf9cfb237bfc40c444786df11e07, data reload: false

------ Round 1 ----------------------------------
q1	17609	4379	4276	4276
q2	2031	350	261	261
q3	10107	1294	716	716
q4	10215	901	328	328
q5	7514	2193	1899	1899
q6	194	179	149	149
q7	889	720	584	584
q8	9254	1374	1160	1160
q9	5383	4838	4808	4808
q10	6848	1934	1565	1565
q11	515	283	282	282
q12	358	377	224	224
q13	17830	4094	3303	3303
q14	248	244	218	218
q15	895	806	806	806
q16	684	702	624	624
q17	653	834	456	456
q18	7002	6535	7450	6535
q19	1225	1037	693	693
q20	432	397	265	265
q21	2919	2316	1905	1905
q22	408	324	294	294
Total cold run time: 103213 ms
Total hot run time: 31351 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4543	4620	4679	4620
q2	312	344	246	246
q3	2273	2877	2360	2360
q4	1456	1855	1436	1436
q5	4544	4582	4665	4582
q6	230	179	138	138
q7	1982	2069	1725	1725
q8	2583	2410	2430	2410
q9	7494	7575	7458	7458
q10	2897	3116	2705	2705
q11	543	463	451	451
q12	688	706	598	598
q13	3861	4292	3539	3539
q14	296	307	343	307
q15	916	812	799	799
q16	666	707	676	676
q17	1085	1291	1311	1291
q18	7295	7396	7253	7253
q19	828	814	827	814
q20	1962	2022	1860	1860
q21	4554	4176	4132	4132
q22	609	554	500	500
Total cold run time: 51617 ms
Total hot run time: 49900 ms

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31008 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 11361bc43588a84daf2be150f6d33ecd045fef26, data reload: false

------ Round 1 ----------------------------------
q1	17606	4403	4275	4275
q2	2045	349	233	233
q3	10172	1339	771	771
q4	10216	793	318	318
q5	8068	2208	1943	1943
q6	249	177	144	144
q7	905	750	600	600
q8	9271	1388	1305	1305
q9	4827	4647	4679	4647
q10	6889	1943	1568	1568
q11	530	316	294	294
q12	395	374	225	225
q13	17786	4139	3257	3257
q14	243	236	219	219
q15	892	809	806	806
q16	670	678	613	613
q17	948	883	467	467
q18	7196	5946	6562	5946
q19	1573	1032	686	686
q20	593	583	402	402
q21	2780	2029	1986	1986
q22	373	341	303	303
Total cold run time: 104227 ms
Total hot run time: 31008 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4755	4557	4565	4557
q2	269	360	261	261
q3	2327	2876	2401	2401
q4	1577	1867	1480	1480
q5	4749	4651	4493	4493
q6	231	182	135	135
q7	1944	1867	1779	1779
q8	2570	2387	2353	2353
q9	7460	7643	7662	7643
q10	2834	3104	2674	2674
q11	530	456	451	451
q12	645	696	545	545
q13	3554	4045	3229	3229
q14	276	302	261	261
q15	818	819	792	792
q16	652	694	649	649
q17	1090	1332	1312	1312
q18	7665	7272	7295	7272
q19	853	805	800	800
q20	1931	2066	1882	1882
q21	4555	4251	4114	4114
q22	551	530	500	500
Total cold run time: 51836 ms
Total hot run time: 49583 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 11361bc43588a84daf2be150f6d33ecd045fef26, data reload: false

query1	0.06	0.05	0.06
query2	0.10	0.05	0.05
query3	0.27	0.09	0.09
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.68	0.67
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.56	0.50	0.49
query10	0.55	0.55	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.63	0.62	0.62
query14	1.06	1.07	1.08
query15	0.88	0.87	0.88
query16	0.41	0.39	0.40
query17	1.15	1.11	1.11
query18	0.23	0.21	0.22
query19	2.10	2.01	2.05
query20	0.02	0.02	0.02
query21	15.39	0.27	0.15
query22	5.17	0.06	0.07
query23	15.88	0.30	0.12
query24	1.44	0.50	0.49
query25	0.12	0.07	0.05
query26	0.14	0.13	0.14
query27	0.06	0.07	0.07
query28	3.88	1.15	0.97
query29	12.55	3.96	3.18
query30	0.31	0.16	0.14
query31	2.82	0.67	0.41
query32	3.24	0.61	0.49
query33	3.27	3.18	3.26
query34	16.10	5.39	4.70
query35	4.81	4.80	4.81
query36	0.65	0.51	0.49
query37	0.12	0.07	0.06
query38	0.08	0.05	0.05
query39	0.04	0.03	0.03
query40	0.21	0.17	0.16
query41	0.09	0.04	0.04
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.95 s
Total hot run time: 28.68 s

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30150 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a, data reload: false

------ Round 1 ----------------------------------
q1	17641	4503	4327	4327
q2	2078	333	229	229
q3	10182	1259	722	722
q4	10190	769	309	309
q5	7526	2140	1911	1911
q6	197	180	147	147
q7	870	723	593	593
q8	9266	1336	1117	1117
q9	4649	4615	4518	4518
q10	6796	1943	1550	1550
q11	494	325	281	281
q12	329	370	218	218
q13	17803	4028	3188	3188
q14	229	233	213	213
q15	883	830	795	795
q16	675	670	627	627
q17	689	758	572	572
q18	6486	5818	5900	5818
q19	1254	968	617	617
q20	494	487	380	380
q21	2465	1817	1738	1738
q22	349	320	280	280
Total cold run time: 101545 ms
Total hot run time: 30150 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4330	4358	4360	4358
q2	259	334	244	244
q3	2053	2678	2291	2291
q4	1321	1724	1300	1300
q5	4295	4314	4472	4314
q6	201	172	135	135
q7	1822	1777	1618	1618
q8	2432	2557	2552	2552
q9	7543	7369	7591	7369
q10	2877	3058	2574	2574
q11	533	467	476	467
q12	721	755	611	611
q13	3910	4294	3660	3660
q14	405	329	294	294
q15	869	788	916	788
q16	804	726	684	684
q17	1134	1332	1410	1332
q18	8305	7908	7688	7688
q19	854	816	841	816
q20	2224	2175	1981	1981
q21	4823	4586	4295	4295
q22	599	608	511	511
Total cold run time: 52314 ms
Total hot run time: 49882 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.11	0.11
query5	0.27	0.25	0.24
query6	1.17	0.67	0.68
query7	0.04	0.02	0.03
query8	0.06	0.04	0.03
query9	0.56	0.49	0.49
query10	0.55	0.54	0.56
query11	0.13	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.62	0.61
query14	1.09	1.04	1.05
query15	0.87	0.86	0.86
query16	0.40	0.39	0.39
query17	1.10	1.14	1.12
query18	0.22	0.21	0.21
query19	2.06	2.01	2.04
query20	0.02	0.01	0.01
query21	15.40	0.26	0.15
query22	5.28	0.06	0.05
query23	16.06	0.28	0.11
query24	1.44	1.39	0.64
query25	0.10	0.08	0.05
query26	0.14	0.14	0.13
query27	0.06	0.07	0.06
query28	4.73	1.15	0.96
query29	12.58	3.93	3.16
query30	0.29	0.13	0.11
query31	2.83	0.64	0.40
query32	3.24	0.60	0.50
query33	3.20	3.18	3.26
query34	16.10	5.40	4.71
query35	4.80	4.82	4.75
query36	0.65	0.50	0.49
query37	0.12	0.07	0.07
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.19	0.16	0.17
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.86 s
Total hot run time: 28.56 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 16.46% (13/79) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.54% (19373/36870)
Line Coverage 36.08% (180305/499744)
Region Coverage 32.43% (139783/431071)
Branch Coverage 33.46% (60555/180977)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 92.41% (73/79) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.71% (25912/36133)
Line Coverage 54.30% (270707/498516)
Region Coverage 51.61% (224722/435457)
Branch Coverage 53.17% (96610/181685)

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30216 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a67c5b9bd45f0da6e527969095a7f5625f3fa8c, data reload: false

------ Round 1 ----------------------------------
q1	17606	4467	4322	4322
q2	2025	391	236	236
q3	10128	1325	733	733
q4	10285	778	308	308
q5	8883	2247	1916	1916
q6	241	177	147	147
q7	898	740	620	620
q8	9267	1367	1139	1139
q9	4751	4662	4692	4662
q10	6881	1951	1539	1539
q11	544	308	293	293
q12	398	374	223	223
q13	17832	4110	3231	3231
q14	242	242	217	217
q15	908	824	812	812
q16	683	675	626	626
q17	970	881	447	447
q18	6570	5753	5677	5677
q19	1433	996	599	599
q20	504	485	390	390
q21	2535	1809	1795	1795
q22	367	321	284	284
Total cold run time: 103951 ms
Total hot run time: 30216 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4421	4386	4369	4369
q2	276	351	250	250
q3	2115	2681	2237	2237
q4	1381	1745	1284	1284
q5	4249	4170	4202	4170
q6	216	180	137	137
q7	1830	1786	1683	1683
q8	2848	2535	2548	2535
q9	7462	7534	7499	7499
q10	2938	2986	2670	2670
q11	552	502	441	441
q12	673	733	649	649
q13	3949	4294	3556	3556
q14	279	309	274	274
q15	872	800	794	794
q16	671	729	720	720
q17	1129	1377	1368	1368
q18	8231	7888	8039	7888
q19	865	954	865	865
q20	2086	2120	2002	2002
q21	4838	4593	4128	4128
q22	574	557	523	523
Total cold run time: 52455 ms
Total hot run time: 50042 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a67c5b9bd45f0da6e527969095a7f5625f3fa8c, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.05
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.28	0.25	0.24
query6	1.16	0.66	0.68
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.56	0.54	0.54
query11	0.14	0.10	0.10
query12	0.14	0.10	0.10
query13	0.62	0.62	0.63
query14	1.05	1.03	1.06
query15	0.87	0.86	0.87
query16	0.38	0.39	0.40
query17	1.13	1.14	1.12
query18	0.23	0.21	0.22
query19	2.11	2.03	2.08
query20	0.02	0.02	0.01
query21	15.39	0.28	0.16
query22	4.97	0.06	0.05
query23	15.84	0.29	0.10
query24	1.57	0.34	0.26
query25	0.12	0.06	0.05
query26	0.15	0.13	0.14
query27	0.09	0.05	0.06
query28	3.10	1.17	0.97
query29	12.54	3.88	3.14
query30	0.27	0.13	0.12
query31	2.81	0.63	0.40
query32	3.24	0.59	0.50
query33	3.20	3.21	3.21
query34	16.17	5.36	4.68
query35	4.82	4.80	4.81
query36	0.65	0.49	0.50
query37	0.11	0.08	0.06
query38	0.08	0.05	0.04
query39	0.05	0.03	0.03
query40	0.20	0.16	0.16
query41	0.08	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.88 s
Total hot run time: 28.26 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 14.75% (18/122) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.54% (19373/36872)
Line Coverage 36.08% (180322/499773)
Region Coverage 32.42% (139779/431085)
Branch Coverage 33.46% (60556/180983)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.16% (110/122) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.28% (26480/36135)
Line Coverage 56.35% (280906/498545)
Region Coverage 53.99% (235119/435471)
Branch Coverage 55.66% (101134/181691)

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30857 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef, data reload: false

------ Round 1 ----------------------------------
q1	17641	4506	4254	4254
q2	2053	347	260	260
q3	10114	1298	772	772
q4	10199	774	326	326
q5	7769	2241	1941	1941
q6	224	179	149	149
q7	903	759	604	604
q8	9278	1398	1206	1206
q9	4916	4671	4618	4618
q10	6866	1949	1548	1548
q11	501	318	296	296
q12	414	377	227	227
q13	17790	4059	3282	3282
q14	240	238	217	217
q15	890	801	815	801
q16	675	680	628	628
q17	715	769	566	566
q18	6690	5828	6148	5828
q19	1606	1037	654	654
q20	535	575	437	437
q21	2736	1965	1993	1965
q22	379	328	278	278
Total cold run time: 103134 ms
Total hot run time: 30857 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4667	4514	4544	4514
q2	282	372	268	268
q3	2381	2935	2492	2492
q4	1463	1816	1489	1489
q5	4697	4721	4558	4558
q6	231	182	141	141
q7	2047	1911	1802	1802
q8	2787	2382	2396	2382
q9	7574	7420	7454	7420
q10	2788	2984	2720	2720
q11	516	478	436	436
q12	705	784	634	634
q13	3589	4012	3262	3262
q14	267	287	259	259
q15	827	784	774	774
q16	633	693	645	645
q17	1090	1280	1355	1280
q18	7620	7445	7395	7395
q19	815	797	835	797
q20	1986	2033	1867	1867
q21	4562	4181	4103	4103
q22	588	525	497	497
Total cold run time: 52115 ms
Total hot run time: 49735 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.04	0.04
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.26	0.25	0.25
query6	1.15	0.69	0.68
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.56	0.48	0.49
query10	0.55	0.54	0.55
query11	0.14	0.10	0.09
query12	0.14	0.10	0.10
query13	0.63	0.61	0.62
query14	1.07	1.05	1.06
query15	0.88	0.87	0.88
query16	0.40	0.40	0.38
query17	1.13	1.13	1.13
query18	0.23	0.22	0.21
query19	2.01	1.96	2.05
query20	0.02	0.01	0.02
query21	15.47	0.27	0.14
query22	4.97	0.07	0.06
query23	15.73	0.30	0.10
query24	1.03	0.34	0.54
query25	0.08	0.07	0.09
query26	0.14	0.13	0.14
query27	0.10	0.06	0.05
query28	4.15	1.17	0.96
query29	12.56	3.96	3.16
query30	0.28	0.14	0.11
query31	2.82	0.62	0.40
query32	3.24	0.60	0.50
query33	3.17	3.23	3.28
query34	16.31	5.42	4.72
query35	4.80	4.88	4.80
query36	0.65	0.52	0.49
query37	0.11	0.06	0.06
query38	0.07	0.05	0.04
query39	0.04	0.02	0.03
query40	0.19	0.16	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.33 s
Total hot run time: 28.33 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 17.19% (22/128) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19370/36872)
Line Coverage 36.07% (180255/499773)
Region Coverage 32.44% (139843/431095)
Branch Coverage 33.45% (60538/180985)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.62% (116/128) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.63% (25885/36135)
Line Coverage 54.25% (270457/498545)
Region Coverage 51.53% (224383/435481)
Branch Coverage 53.06% (96413/181693)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3af7795 into apache:master Feb 7, 2026
28 of 30 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Feb 9, 2026
…0530)

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove
dependency on the deleted wrapper_field.h header. Replace WrapperField
usage with hardcoded min/max values for IP addresses and direct string
comparisons for other types. Test logic and coverage are preserved.

- Remove wrapper_field.h includes
- Replace WrapperField::create_by_type() and related calls with explicit
values
- Update test data structures to remove wrapper field expectations
- Simplify nullable string tests to use test string directly
- Update comments to reflect serde-only testing approach

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
yiguolei pushed a commit that referenced this pull request Feb 10, 2026
…60593)

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove
dependency on the deleted wrapper_field.h header. Replace WrapperField
usage with hardcoded min/max values for IP addresses and direct string
comparisons for other types. Test logic and coverage are preserved.

- Remove wrapper_field.h includes
- Replace WrapperField::create_by_type() and related calls with explicit
values
- Update test data structures to remove wrapper field expectations
- Simplify nullable string tests to use test string directly
- Update comments to reflect serde-only testing approach

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change. - [ ] No code files have been
changed. - [ ] Other reason <!-- Add your reason? -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants