Skip to content

[fix](test) Remove wrapper_field dependency from unit tests (#60530)#60593

Merged
yiguolei merged 4 commits intoapache:branch-4.0from
Gabriel39:pick_0209
Feb 10, 2026
Merged

[fix](test) Remove wrapper_field dependency from unit tests (#60530)#60593
yiguolei merged 4 commits intoapache:branch-4.0from
Gabriel39:pick_0209

Conversation

@Gabriel39
Copy link
Contributor

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove dependency on the deleted wrapper_field.h header. Replace WrapperField usage with hardcoded min/max values for IP addresses and direct string comparisons for other types. Test logic and coverage are preserved.

  • Remove wrapper_field.h includes
  • Replace WrapperField::create_by_type() and related calls with explicit values
  • Update test data structures to remove wrapper field expectations
  • Simplify nullable string tests to use test string directly
  • Update comments to reflect serde-only testing approach

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
  • This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
  • Yes.

  • Confirm the release note

  • Confirm test cases

  • Confirm document

  • Add branch pick label


What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…0530)

Update FromStringTest, TextSerde, and CsvSerde unit tests to remove
dependency on the deleted wrapper_field.h header. Replace WrapperField
usage with hardcoded min/max values for IP addresses and direct string
comparisons for other types. Test logic and coverage are preserved.

- Remove wrapper_field.h includes
- Replace WrapperField::create_by_type() and related calls with explicit
values
- Update test data structures to remove wrapper field expectations
- Simplify nullable string tests to use test string directly
- Update comments to reflect serde-only testing approach

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
@Gabriel39 Gabriel39 requested a review from yiguolei as a code owner February 9, 2026 01:57
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 16.30% (22/135) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.00% (19110/36054)
Line Coverage 36.18% (177947/491881)
Region Coverage 32.76% (137845/420716)
Branch Coverage 33.68% (59759/177410)

@yiguolei yiguolei merged commit d189b9d into apache:branch-4.0 Feb 10, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants