[fix](test) Remove wrapper_field dependency from unit tests (#60530)#60593
Merged
yiguolei merged 4 commits intoapache:branch-4.0from Feb 10, 2026
Merged
[fix](test) Remove wrapper_field dependency from unit tests (#60530)#60593yiguolei merged 4 commits intoapache:branch-4.0from
yiguolei merged 4 commits intoapache:branch-4.0from
Conversation
…0530) Update FromStringTest, TextSerde, and CsvSerde unit tests to remove dependency on the deleted wrapper_field.h header. Replace WrapperField usage with hardcoded min/max values for IP addresses and direct string comparisons for other types. Test logic and coverage are preserved. - Remove wrapper_field.h includes - Replace WrapperField::create_by_type() and related calls with explicit values - Update test data structures to remove wrapper field expectations - Simplify nullable string tests to use test string directly - Update comments to reflect serde-only testing approach Issue Number: close #xxx Related PR: #xxx Problem Summary: None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update FromStringTest, TextSerde, and CsvSerde unit tests to remove dependency on the deleted wrapper_field.h header. Replace WrapperField usage with hardcoded min/max values for IP addresses and direct string comparisons for other types. Test logic and coverage are preserved.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
None
Test
This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason
Behavior changed:
Does this need documentation?
Yes.
Confirm the release note
Confirm test cases
Confirm document
Add branch pick label
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)