Remove the findDOMNode usage from ContextMenu #5588
Merged
canova merged 2 commits intofirefox-devtools:mainfrom Sep 3, 2025
Merged
Remove the findDOMNode usage from ContextMenu #5588canova merged 2 commits intofirefox-devtools:mainfrom
canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5588 +/- ##
==========================================
- Coverage 85.78% 85.77% -0.01%
==========================================
Files 309 309
Lines 30403 30391 -12
Branches 8370 8367 -3
==========================================
- Hits 26080 26068 -12
Misses 3902 3902
Partials 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
reviewed
Sep 3, 2025
Comment on lines
30
to
31
| this._contextMenuWrapper.addEventListener( | ||
| 'mousedown', |
Contributor
There was a problem hiding this comment.
Since we now have our own element anyway, couldn't we just use <div onMouseDown={this._onMouseDown}>?
Member
Author
There was a problem hiding this comment.
Ah, lol, yes exactly :D It makes perfect sense as it makes it a lot cleaner! Changed it.
canova
force-pushed
the
finddomnode-contextmenu
branch
from
d027f86 to
84d1c38
Compare
mstange
approved these changes
Sep 3, 2025
This was referenced Sep 4, 2025
canova
added a commit
that referenced
this pull request
Sep 5, 2025
Changes: [Markus Stange] Some path fixes (#5581) [depfu[bot]] Update all Yarn dependencies (2025-09-03) (#5585) [Nazım Can Altınova] Remove the findDOMNode usage from ContextMenu (#5588) [Markus Stange] Replace @fetch-mock/jest with plain fetch-mock (#5575) [Ryan Hunt] Replace zee-worker.js with compression streams API (#5584) [Markus Stange] Remove unused FilterNavigatorBar animations (#5591) [Markus Stange] Use different ports for start-prod and start-examples (#5592) [Markus Stange] Remove SharedArrayBuffer workaround (#5596) [Jeff Muizelaar] Make time after responseEnd have a more accurate name (#5582) [Ryan Hunt] Move compression and decompression to a worker (#5597) [Markus Stange] Remove Flow and no-TypeScript settings from .vscode/settings.json (#5601) [Markus Stange] Simplify the eslint command in package.json so that eslint.config.mjs is the only place you need to look if you want to know if a file is being checked (#5600) [Markus Stange] Fix search filtering (#5599) [Nazım Can Altınova] 🔃 Sync: l10n -> main (September 5, 2025) (#5603) And thanks to our localizers: de: mstange tr: Fernando Javier tr: Rua tr: Selim Şumlu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findDOMNodeis deprecated in react 18 and it's removed from version 19. It's one of the blockers of the React 19 upgrade for us right now. There are a few morefindDOMNodeusages, but I expect to look at them next.It looks like there 2 more places where we use
findDOMNode:withSizehigher order componentCSSTransitioncomponent that's from thereact-transition-grouppackage (internally)."Hide whitespace" option in github would make it easier to review the snapshot tests as we only wrap the component with a div.
Production / Deploy preview