Skip to content

Move compression and decompression to a worker#5597

Merged
mstange merged 3 commits intofirefox-devtools:mainfrom
eqrion:background-compression
Sep 4, 2025
Merged

Move compression and decompression to a worker#5597
mstange merged 3 commits intofirefox-devtools:mainfrom
eqrion:background-compression

Conversation

@eqrion
Copy link
Contributor

@eqrion eqrion commented Sep 4, 2025

No description provided.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it passes tests. Just need the license header in the new file.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (9d8a626) to head (b282779).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/gz.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5597      +/-   ##
==========================================
+ Coverage   85.73%   85.81%   +0.07%     
==========================================
  Files         309      309              
  Lines       30386    30371      -15     
  Branches     8364     8362       -2     
==========================================
+ Hits        26052    26063      +11     
+ Misses       3913     3887      -26     
  Partials      421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange merged commit f6db0d3 into firefox-devtools:main Sep 4, 2025
14 of 15 checks passed
Comment on lines +24 to +25
DecompressionStream,
CompressionStream,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you figure out that this part was needed? I just hit the same issue for Response and I was not having a good time figuring it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I was skimming at the jest setup code and kind of just got lucky with a guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, fair enough!

@canova canova mentioned this pull request Sep 5, 2025
canova added a commit that referenced this pull request Sep 5, 2025
Changes:

[Markus Stange] Some path fixes (#5581)
[depfu[bot]] Update all Yarn dependencies (2025-09-03) (#5585)
[Nazım Can Altınova] Remove the findDOMNode usage from ContextMenu
(#5588)
[Markus Stange] Replace @fetch-mock/jest with plain fetch-mock (#5575)
[Ryan Hunt] Replace zee-worker.js with compression streams API (#5584)
[Markus Stange] Remove unused FilterNavigatorBar animations (#5591)
[Markus Stange] Use different ports for start-prod and start-examples
(#5592)
[Markus Stange] Remove SharedArrayBuffer workaround (#5596)
[Jeff Muizelaar] Make time after responseEnd have a more accurate name
(#5582)
[Ryan Hunt] Move compression and decompression to a worker (#5597)
[Markus Stange] Remove Flow and no-TypeScript settings from
.vscode/settings.json (#5601)
[Markus Stange] Simplify the eslint command in package.json so that
eslint.config.mjs is the only place you need to look if you want to know
if a file is being checked (#5600)
[Markus Stange] Fix search filtering (#5599)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (September 5, 2025) (#5603)

And thanks to our localizers:

de: mstange
tr: Fernando Javier
tr: Rua
tr: Selim Şumlu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants