Remove unused FilterNavigatorBar animations#5591
Merged
mstange merged 1 commit intofirefox-devtools:mainfrom Sep 4, 2025
Merged
Remove unused FilterNavigatorBar animations#5591mstange merged 1 commit intofirefox-devtools:mainfrom
mstange merged 1 commit intofirefox-devtools:mainfrom
Conversation
mstange
force-pushed
the
remove-unused-filternavigatorbar-animations
branch
from
ab55ef0 to
0ecad6e
Compare
mstange
force-pushed
the
remove-unused-filternavigatorbar-animations
branch
from
0ecad6e to
2a83c47
Compare
mstange
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 309 309
Lines 30390 30390
Branches 8363 8365 +2
=======================================
Hits 26055 26055
Misses 3914 3914
Partials 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
Sep 4, 2025
Comment on lines
+23
to
+25
| /* Note: no overflow: hidden for historical reasons - we wanted to see | ||
| an animation for items at the end while they were fading out, but | ||
| we have removed this animation in the meantime */ |
Member
There was a problem hiding this comment.
nit: I don't know how useful this comment is now, I don't mind keeping it but maybe we can remove it all together.
canova
added a commit
that referenced
this pull request
Sep 5, 2025
Changes: [Markus Stange] Some path fixes (#5581) [depfu[bot]] Update all Yarn dependencies (2025-09-03) (#5585) [Nazım Can Altınova] Remove the findDOMNode usage from ContextMenu (#5588) [Markus Stange] Replace @fetch-mock/jest with plain fetch-mock (#5575) [Ryan Hunt] Replace zee-worker.js with compression streams API (#5584) [Markus Stange] Remove unused FilterNavigatorBar animations (#5591) [Markus Stange] Use different ports for start-prod and start-examples (#5592) [Markus Stange] Remove SharedArrayBuffer workaround (#5596) [Jeff Muizelaar] Make time after responseEnd have a more accurate name (#5582) [Ryan Hunt] Move compression and decompression to a worker (#5597) [Markus Stange] Remove Flow and no-TypeScript settings from .vscode/settings.json (#5601) [Markus Stange] Simplify the eslint command in package.json so that eslint.config.mjs is the only place you need to look if you want to know if a file is being checked (#5600) [Markus Stange] Fix search filtering (#5599) [Nazım Can Altınova] 🔃 Sync: l10n -> main (September 5, 2025) (#5603) And thanks to our localizers: de: mstange tr: Fernando Javier tr: Rua tr: Selim Şumlu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
On the production branch I don't see any animations in the breadcrumb bar where the time range filters are displayed, when I make a selection, commit a selection or "pop" selections. No animations in the call tree transform list either.
Since nobody has noticed, let's just remove the code for them, because this gets rid of some of the uses of react-transition-group, which is one of our barriers to upgrading React (#5590).