Fixes #64669: Keep extensions' search input value after window reload#68198
Closed
vldmrkl wants to merge 206 commits intomicrosoft:masterfrom
Closed
Fixes #64669: Keep extensions' search input value after window reload#68198vldmrkl wants to merge 206 commits intomicrosoft:masterfrom
vldmrkl wants to merge 206 commits intomicrosoft:masterfrom
Conversation
|
|
sandy081
requested changes
Feb 13, 2019
src/vs/workbench/contrib/extensions/electron-browser/extensionsViewlet.ts
Outdated
Show resolved
Hide resolved
sandy081
requested changes
Feb 18, 2019
| protected saveState(): void { | ||
| const value = this.searchBox.getValue(); | ||
| this.searchViewletState['query.value'] = value; | ||
| if (value.indexOf('@installed') >= 0) { |
Member
There was a problem hiding this comment.
May be you should use the following to check if it is an installed query or not
Member
|
@klymenkoo Tested it and it does not work. I changed extensions viewlet to show installed extensions and did refresh. After refresh, input box shows
|
Contributor
Author
|
@sandy081 I added triggerSearch() function if there is value in searchBox while creation. Should work now. Let me know if there is anything else needed to be fixed. |
Revert the default custom title bar behavior on Linux
…oundingPairs (microsoft#68833) Triple-stash {{{ ... }}} is used to surround an expression that should not be escaped for HTML Having the option to enable surroundingPairs for brace would simplify the editing experience
* add functionality to hide open context menu fix toggling of ... menu on windows fix toggling of global activity bar menu on windows fix position of global activity bar menu on windows fixes microsoft#62413 fixes microsoft#61766 * addressing feedback * linting error * updating to eat mouse click to dismiss menu * remove native context menu changes as unnecessary * use an invisible div to block mouse * move logic into context menu handler * sanitize SNAP variables * rename update.channel to update.mode fixes microsoft#67407 * dervie status background from editor widget background
Fixes microsoft#59606 This matches how the editor find widget works
Member
|
@klymenkoo Thanks for the changes. Merged it by cherry picking commit by commit as I kinda messed up with merging. Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes issue #64669
As discussed on the issue page, I created viewletState for searchBox in order to save value of the search box, and use it when it is re-rendered.
CC: @sandy081