Skip to content

Comments

consolidate bootstrap docs#107116

Merged
bors merged 1 commit intorust-lang:masterfrom
onur-ozkan:consolidate-bootstrap-docs
Feb 5, 2023
Merged

consolidate bootstrap docs#107116
bors merged 1 commit intorust-lang:masterfrom
onur-ozkan:consolidate-bootstrap-docs

Conversation

@onur-ozkan
Copy link
Contributor

@onur-ozkan onur-ozkan commented Jan 20, 2023

With this diff, I tried to consolidate bootstrap documentations and remove the duplicated informations.

Coupled with rust-lang/rustc-dev-guide#1563

Resolves #90686

Signed-off-by: ozkanonur work@onurozkan.dev

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
@onur-ozkan onur-ozkan mentioned this pull request Jan 20, 2023
Merged
@onur-ozkan
Copy link
Contributor Author

onur-ozkan commented Jan 20, 2023

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned Mark-Simulacrum Jan 20, 2023
@albertlarsan68
Copy link
Member

albertlarsan68 commented Jan 20, 2023

I think those changes should wait for the rustc-dev-guide to be updated, to be sure that there is not a moment where the documentation does not exist anywhere.
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
@compiler-errors compiler-errors changed the title consolidate bootstrap docs r=ozkanonur consolidate bootstrap docs Jan 20, 2023
@compiler-errors
Copy link
Contributor

compiler-errors commented Jan 20, 2023

@ozkanonur you don't need to put r= in your PR titles or commit messages. bors will automatically add those to merge commits when the pr is approved.

(Unless you're doing it for some other reason, which I think may be confusing because r= is already used to mean "approved by" in the rust repo)

@onur-ozkan onur-ozkan force-pushed the consolidate-bootstrap-docs branch 2 times, most recently from d3adf3a to d0fa05c Compare January 27, 2023 10:51
albertlarsan68
albertlarsan68 reviewed Jan 27, 2023
View reviewed changes
@onur-ozkan onur-ozkan force-pushed the consolidate-bootstrap-docs branch from f3fd173 to 9060e70 Compare January 27, 2023 14:19
@onur-ozkan onur-ozkan added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 31, 2023
@onur-ozkan
Copy link
Contributor Author

onur-ozkan commented Jan 31, 2023

rust-lang/rustc-dev-guide#1563 (comment) is merged, so this is no longer blocked.

jyn514
jyn514 reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, thanks. I left a few suggestions below, and I also think we should link to this README from the dev guide.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
@onur-ozkan onur-ozkan force-pushed the consolidate-bootstrap-docs branch 2 times, most recently from 939588a to c447e86 Compare February 1, 2023 09:27
@onur-ozkan onur-ozkan added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 1, 2023
jyn514
jyn514 reviewed Feb 3, 2023
View reviewed changes
src/bootstrap/README.md Outdated
Copy link
Member

@jyn514 jyn514 Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need to mention this in the docs, but I'm hoping at some point to distinguish these "public" sysroots from the one's we're using for bootstrap internally: https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Performing.20.60.2E.2Fx.2Epy.20dist.60.20results.20in.20a.20broken.20compiler.20at.20.2E.2E.2E

@onur-ozkan
consolidate bootstrap docs
6558326 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the consolidate-bootstrap-docs branch from fa73de4 to 6558326 Compare February 4, 2023 17:17
@onur-ozkan onur-ozkan mentioned this pull request Feb 4, 2023
Merged
@jyn514
Copy link
Member

jyn514 commented Feb 4, 2023

Thank you!!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 4, 2023

📌 Commit 6558326 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2023
@bors
Auto merge of rust-lang#107672 - matthiaskrgr:rollup-7e6dbuk, r=matth…
50d3ba5 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#107116 (consolidate bootstrap docs)
 - rust-lang#107646 (Provide structured suggestion for binding needing type on E0594)
 - rust-lang#107661 (Remove Esteban from review queues for a while)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3666fa0 into rust-lang:master Feb 5, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 5, 2023
@onur-ozkan onur-ozkan deleted the consolidate-bootstrap-docs branch February 5, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@albertlarsan68 albertlarsan68 albertlarsan68 left review comments

+1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514 jyn514

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

Consolidate bootstrap documentation

8 participants

@onur-ozkan @rustbot @albertlarsan68 @compiler-errors @jyn514 @bors @bjorn3 @Mark-Simulacrum