Provide structured suggestion for binding needing type on E0594#107646
Merged
bors merged 2 commits intorust-lang:masterfrom Feb 5, 2023
Merged
Provide structured suggestion for binding needing type on E0594#107646bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| } | ||
| let hir_map = self.infcx.tcx.hir(); | ||
| let pat = loop { | ||
| // Poor man's try block |
Contributor
There was a problem hiding this comment.
Can we just use a try block here? This is the compiler after all. Or a closure (|| {})() is typically what I see being used instead.
Contributor
There was a problem hiding this comment.
#![feature(try_blocks)] is already enabled in rustc_borrowck too 😃
Contributor
Author
There was a problem hiding this comment.
Ended up doing let chains instead :)
Contributor
|
r=me after the nits tho |
Contributor
|
thanks @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit e6c56cd with merge 54d8cbff5aaf4aec267f2f9b2c8c1096f15c351e... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#107116 (consolidate bootstrap docs) - rust-lang#107646 (Provide structured suggestion for binding needing type on E0594) - rust-lang#107661 (Remove Esteban from review queues for a while) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially address #45405.