Skip to content

TICKET-614: Add case sensitivy to group search - #7938

Merged
david-yz-liu merged 5 commits into
masterfrom
TICKET-614_add_case_sensitivity_to_group_search
May 31, 2026
Merged

TICKET-614: Add case sensitivy to group search#7938
david-yz-liu merged 5 commits into
masterfrom
TICKET-614_add_case_sensitivity_to_group_search

Conversation

@Naragod

@Naragod Naragod commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed Changes

Add case sensitivity to group search.

Screenshots of your changes (if applicable)
Screen.Recording.2026-05-08.at.5.04.27.PM.mov
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@Naragod Naragod added this to the v2.9.7 milestone May 8, 2026
@Naragod
Naragod requested a review from donny-wong May 8, 2026 21:05
@Naragod Naragod linked an issue May 8, 2026 that may be closed by this pull request
Bug: Case-insensitive group filtering for 'A' in Graders tab #7927
Closed
@coveralls

coveralls commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 26714803411

Coverage increased (+0.03%) to 90.311%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: 22 of 22 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 49979
Covered Lines: 46101
Line Coverage: 92.24%
Relevant Branches: 2175
Covered Branches: 1000
Branch Coverage: 45.98%
Branches in Coverage %: Yes
Coverage Strength: 122.78 hits per line
💛 - Coveralls

donny-wong
donny-wong reviewed May 12, 2026
View reviewed changes

@donny-wong donny-wong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Naragod , looks good. Please update branch and I will approve it at that time. Thank you.

@Naragod
Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from 00a015a to 9765181 Compare May 12, 2026 23:27
@Naragod
Naragod requested a review from donny-wong May 12, 2026 23:27
@donny-wong
donny-wong requested a review from david-yz-liu May 13, 2026 02:02
david-yz-liu
david-yz-liu reviewed May 21, 2026
View reviewed changes

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naragod Nice work! Sorry I took a while to review this. The UI is very nice and I appreciate the attention to consistency across components.

I left two comments, one of which is describes a change to the approach that causes a bit of work but I think will result in a nice simplification of these changes. Please feel free to message on Slack if you'd like to chat further about this.

Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated
Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated
@Naragod
Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from e4623a5 to 34449a4 Compare May 25, 2026 03:31
donny-wong
donny-wong approved these changes May 26, 2026
View reviewed changes

@donny-wong donny-wong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Naragod. Please resolve branch conflicts. Thanks.

david-yz-liu
david-yz-liu reviewed May 28, 2026
View reviewed changes

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naragod nice work, the change ended up being even simpler than I thought! I left a few more comments about functionality and some code cleanup. As Donny noted, please do also update with master and resolve the conflict.

Comment thread app/javascript/Components/annotation_usage_panel.jsx Outdated
Comment thread app/javascript/Components/graders_manager.jsx
super(props);
this.state = {
filtered: [],
columns: this.getColumns(props.showSections, props.sections, props.showCoverage),

@david-yz-liu david-yz-liu May 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not necessary. Please keep the changes to just the filter and filterMethod properties for the column with the new case-(in)sensitive filter.

@Naragod Naragod May 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread app/javascript/Components/groups_manager.jsx Outdated
Comment thread app/javascript/Components/submission_table.jsx Outdated
Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated
Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated
@Naragod
Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from 34449a4 to 4fc364c Compare May 30, 2026 22:03
@Naragod
Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from 4fc364c to add8939 Compare May 30, 2026 22:04
@Naragod
Naragod requested a review from david-yz-liu May 30, 2026 22:07
@david-yz-liu
david-yz-liu force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from 597a094 to 10df6ee Compare May 31, 2026 14:06
david-yz-liu
david-yz-liu approved these changes May 31, 2026
View reviewed changes

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Naragod! I did a final merge from master and reverted the change to package-lock.json. I'm not sure what happened there, perhaps a npm version mismatch that we can investigate later.

@david-yz-liu
david-yz-liu merged commit 053444f into master May 31, 2026
13 of 14 checks passed
@david-yz-liu
david-yz-liu deleted the TICKET-614_add_case_sensitivity_to_group_search branch May 31, 2026 15:22
philipkukulak pushed a commit that referenced this pull request Jun 1, 2026
@Naragod @philipkukulak
Added case sensitivity to group search (#7938)
5d4bf87 
This adds a new caseSensitiveTextFilter table component for doing case-sensitive search.
@donny-wong donny-wong modified the milestones: v2.9.7, v2.10.1 Jun 1, 2026
@david-yz-liu david-yz-liu mentioned this pull request Jun 16, 2026
Closed
9 tasks
Naragod added a commit that referenced this pull request Jul 27, 2026
@Naragod @philipkukulak
@dependabot @david-yz-liu @YheChen @mrafie1 @claude @danielrafailov1 @donny-wong @akarki2005 @pre-commit-ci
V2.10.1 (#8067)
0f4120e 
* Implement GET and PATCH /overall_comment API routes (#7963)

Closes #7708

* build(deps): bump puma from 7.2.0 to 7.2.1 (#7994)

Bumps [puma](https://github.com/puma/puma) from 7.2.0 to 7.2.1.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/main/History.md)
- [Commits](puma/puma@v7.2.0...v7.2.1)

---
updated-dependencies:
- dependency-name: puma
  dependency-version: 7.2.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump dompurify from 3.4.0 to 3.4.9 (#8005)

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.0 to 3.4.9.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.4.0...3.4.9)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactored SubmissionFilePanel subcomponents into functional style (#7969)

* build(deps): bump net-imap from 0.6.4 to 0.6.4.1 (#7995)

Bumps [net-imap](https://github.com/ruby/net-imap) from 0.6.4 to 0.6.4.1.
- [Release notes](https://github.com/ruby/net-imap/releases)
- [Commits](ruby/net-imap@v0.6.4...v0.6.4.1)

---
updated-dependencies:
- dependency-name: net-imap
  dependency-version: 0.6.4.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump dompurify from 3.4.9 to 3.4.11 (#8009)

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.9 to 3.4.11.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.4.9...3.4.11)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.11
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added missing NOT NULL db constraints and presence validations (#7965)

Issues detected by active_record_doctor

* build(deps): bump nokogiri from 1.19.3 to 1.19.4 (#8010)

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.19.3 to 1.19.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.19.3...v1.19.4)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-version: 1.19.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump ws from 8.18.3 to 8.21.1 (#8058)

Bumps [ws](https://github.com/websockets/ws) from 8.18.3 to 8.21.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.18.3...8.21.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-version: 8.21.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added case sensitivity to group search (#7938)

This adds a new caseSensitiveTextFilter table component for doing case-sensitive search.

* build(deps): bump concurrent-ruby from 1.3.6 to 1.3.7 (#8011)

Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.3.6 to 1.3.7.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases)
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md)
- [Commits](ruby-concurrency/concurrent-ruby@v1.3.6...v1.3.7)

---
updated-dependencies:
- dependency-name: concurrent-ruby
  dependency-version: 1.3.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactored group creation to set group_name and repo_name pre-validation (#7975)

Also add NOT NULL constraint to groups.group_name column

* Simplified Chart.js usage (#7987)

* Migrated MarkingSchemesTable to React Table v8 (#7985)

* Fixed merge commits being incorrectly attributed as latest submission (#7988)

When an instructor cloned a student repo, made a local commit, then merged and
pushed, the merge commit was treated as the latest submission for the student's
files. This inflated late penalties and showed the instructor's name as author.

`entry_changed?` returned true for a merge commit whenever the file differed from
*any* parent — including the instructor's branch that simply didn't have the file
yet. The fix: for merge commits (2+ parents), only return true when the result
differs from *all* parents. If the merged content matches at least one parent the
merge was trivial for that path and should not be counted as a new modification.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Refactored criterion keyboard navigation (#7989)

* Moved criterion and level keyboard handlers into React components (MarksPanel and RubricCrtierionInput)
* Fixed keyboard criterion navigation when flexible/checkbox inputs were focused
* Ensured criterion navigation causes selected criterion to scroll into view

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fixed navbar MarkUs logo link URL on mobile (#7990)

* Added confirmation when uploading scans for a template with no divisions (#7993)

* Fixed tester spec upload when spec contains non-existent criterion (#7998)

Closes #7528

* Migrated SummaryPanel marks chart modal to use react-modal (#7996)

* Added release process automation scripts (#7914)

* Fixed SVG rendering by converting base64 SVG data URIs to inline <svg> (#8001)

* Added pagination to Admin Users table for performance (#7997)

* Added confirm dialog when a student submits during late period (#8003)

* Reorganized locale strings from config/locales/en.yml (#8012)

* Used native HTML required validation on modal upload inputs (#8016)

* Refactored group creation job updates to use websockets (#8020)

* Updated database indexes (#8018)

- Enforce model uniqueness validations
- Remove redundant indexes

These were detected by active_record_doctor:missing_unique_indexes and active_record_doctor:extraneous_indexes.

* Migrated graders_manager.jsx tables to react-table v8 (#8014)

* Support all annotation types in add_annotations API route (#8007)

* Fixed result annotation links to display correct file (#8017)

* Updated PDFViewer to persist PDF scroll across submissions (#8004)

* Added assignment grades upload feature (#8008)

* bump jwt from 2.10.3 to 3.2.0 (#8039)

* Fix LTI test JWK fixture to use 2048-bit key for jwt 3.0 compatibility

* Fixed selection column header checkbox in v8 tables (#8037)

* Added migrations to add missing timestamp columns and foreign key constraints (#8040)

* Fixed assignment dropdown menu redirection from Assignments#index (#8043)

* Fixed escaping of HTML annotation start_node and end_node attributes (#8064)

* update changelog with new release v2.10.1 [ci skip]

* update markus version

* Fix rubocop ArrayIntersect and spec path offenses

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Install postgresql-client-17 for CI pg_dump compatibility

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: philipkukulak <philip.kukulak@utoronto.ca>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Liu <david@cs.toronto.edu>
Co-authored-by: Yanzhen Chen <yanzhenchen123@gmail.com>
Co-authored-by: Muhammad <rafie.muhammad2007@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Daniel Rafailov <74218740+danielrafailov1@users.noreply.github.com>
Co-authored-by: donny-wong <141858744+donny-wong@users.noreply.github.com>
Co-authored-by: Aayush Karki <147123757+akarki2005@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-yz-liu david-yz-liu david-yz-liu approved these changes
@donny-wong donny-wong donny-wong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.10.1

Development

Successfully merging this pull request may close these issues.

Bug: Case-insensitive group filtering for 'A' in Graders tab

4 participants

@Naragod @coveralls @david-yz-liu @donny-wong