VS Code issues relating to new terminal activation feature

[karrtikr]

This is to track outstanding VS Code bugs so terminal activation feature can stabilize:

• .zshrc is overriding the environment variable set by shell integration on macOS vscode#205102
• Prepending using shell integration does not work for zsh, even when shell integration is activated vscode#205133
• Expose API whether shell integration is working or not vscode#205058
• onDidExecuteTerminalCommand does not fire events for hidden terminal vscode#199611
• Environment collection should not be applied on hidden terminals (non-windows) vscode#197187
  • Provide a way to exempt a terminal from applying any env collections vscode#194819
    • This is not needed if #197187 is solved
  • Resolve Provide a way to exempt a terminal from applying any env collections vscode#194819 (comment)
  • Resolve Environment collection should not be applied on hidden terminals (non-windows) vscode#197187 (comment)
• onDidWriteTerminalData event does not contain shell integration sequences for hidden terminals vscode#204616
• Prepending using shell integration does not work for fish when using starship prompt vscode#208465
• Ensure we use correct workspace folder for remote terminals vscode#180486
  • Multiroot workspaces for remote scenarios does not work currently because of this
• Expose shell integration command knowledge to extensions vscode#145234
• Explore terminal buffer API vscode#207504
  • We would need this to get command output, if microsoft/vscode#145234 doesn't cover it.
• Shell integration isn't enabled for Debug terminals vscode#204694
• Shell integration isn't enabled for Task terminals vscode#205177
• Environment collection replace API strips equals sign at the end vscode#197603

Our follow up action items based on that:

• Adopt to using VS Code API to access terminal output #22128
• If automatic shell integration is failing to activate environment, recommend users to do manual installation #23113
• Enable experiment for multiroot remote scenarios:

  vscode-python/src/client/common/experiments/helpers.ts

  Lines 12 to 17 in 0438813

  	export function inTerminalEnvVarExperiment(experimentService: IExperimentService): boolean {
  	if (!isTestExecution() && env.remoteName && workspace.workspaceFolders && workspace.workspaceFolders.length > 1) {
  	// TODO: Remove this if statement once https://github.com/microsoft/vscode/issues/180486 is fixed.
  	traceInfo('Not enabling terminal env var experiment in multiroot remote workspaces');
  	return false;
  	}

Issue to keep in mind:
PREPEND: #21906

[KayvanShah1]

Recently, after the pylance update and vscode update the Python environment activation feature doesn't activate the environment in the terminal while it shows up on the bottom status bar

[karrtikr]

@KayvanShah1 note Git bash isn't officially supported by the Python extension, which is what you seem to be running into. Can you change the shell using Select default profile command to Command prompt or Powershell?

If that doesn't work, please open a new issue using Python: Report Issue command and we'll be happy to take a look.

[JoelFeiner-viimed]

I'm having this issue with zsh on Linux, pyenv and pipenv. Screenshot:

I downgraded to previous versions and it still doesn't work. I'm at a loss for what the issue is. It simply no longer runs the source ...activate command like it used to. No combination of settings or versions seems to make a difference. I wonder if there is something cached?

Relevant config in settings.json:

        "python.defaultInterpreterPath": "/home/joel/.local/share/virtualenvs/edge-K9fIdVPi/bin/python",
        "python.envFile": "${workspaceFolder}/edge/.env",
        "python.pipenvPath": "/home/joel/.local/share/virtualenvs/edge-K9fIdVPi/bin/pipenv",

[gabethehuman]

I have this annoying issue where VSCode adds stuff to my PS1. In this case I'm using pyenv, but it happens with conda as well.

system is what should be in PS1, the yt part is there only because I selected it in the bottom right corner in the Python extension.

Any chance it's related to any of the issues in the main post?
Similar to @JoelFeiner-viimed I tried downgrading the extension or switching to the pre-release version, without any luck.

[karrtikr]

@gabethehuman Opened #22882 for you to help out.

[karrtikr]

notes.md