Skip to content

Fill the specified ref in webhook test payload #20961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 4 commits into from
Sep 4, 2022
Merged

Fill the specified ref in webhook test payload #20961

lafriks merged 4 commits into from
Sep 4, 2022

Conversation

@wolfogre
Copy link
Member

@wolfogre wolfogre commented Aug 26, 2022 •
edited
Loading

The webhook payload should use the right ref when it‘s specified in the testing request.

The compare URL should not be empty, a URL like compare/A...A seems useless in most cases but is helpful when testing.

@wolfogre wolfogre marked this pull request as ready for review August 26, 2022 02:32
@wolfogre wolfogre marked this pull request as draft August 26, 2022 02:39
@wolfogre wolfogre marked this pull request as ready for review August 26, 2022 03:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #20961 (61597ed) into main (6c4688e) will increase coverage by 0.00%.
The diff coverage is 31.81%.

@@           Coverage Diff           @@
##             main   #20961   +/-   ##
=======================================
  Coverage   47.05%   47.06%           
=======================================
  Files         997      997           
  Lines      136499   136515   +16     
=======================================
+ Hits        64231    64252   +21     
+ Misses      64387    64382    -5     
  Partials     7881     7881
Impacted Files Coverage Δ
routers/web/repo/webhook.go 2.14% <0.00%> (-0.01%) ⬇️
routers/api/v1/repo/hook.go 18.91% <38.88%> (+0.14%) ⬆️
modules/process/manager_exec.go 86.04% <0.00%> (-6.98%) ⬇️
modules/git/repo_base_nogogit.go 71.69% <0.00%> (-3.78%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
modules/queue/queue_channel.go 80.55% <0.00%> (-2.78%) ⬇️
services/pull/pull.go 40.34% <0.00%> (-0.47%) ⬇️
models/issues/comment.go 50.00% <0.00%> (-0.44%) ⬇️
models/activities/notification.go 63.32% <0.00%> (+1.09%) ⬆️
modules/notification/ui/ui.go 60.71% <0.00%> (+1.78%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 26, 2022
@wolfogre wolfogre marked this pull request as draft August 26, 2022 03:52
@wolfogre wolfogre marked this pull request as ready for review August 26, 2022 04:00
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 26, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Aug 26, 2022
@wolfogre
Copy link
Member Author

wolfogre commented Aug 27, 2022 •
edited
Loading

I think a backport/v1.17 label is needed, and I will pick this pr to the release/1.17 branch when it has been merged.

Could other maintainers please help to review it?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2022
wxiaoguang
wxiaoguang reviewed Sep 3, 2022
View reviewed changes
@lafriks lafriks merged commit 93a610a into go-gitea:main Sep 4, 2022
@zeripath
Copy link
Contributor

zeripath commented Sep 4, 2022

Please send backport

@wolfogre wolfogre mentioned this pull request Sep 4, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Sep 4, 2022
zeripath pushed a commit that referenced this pull request Sep 4, 2022
@wolfogre
Fill the specified ref in webhook test payload (#20961) (#21055)
ea38455 
Backport #20961

The webhook payload should use the right ref when it‘s specified in the testing request.

The compare URL should not be empty, a URL like `compare/A...A` seems useless in most cases but is helpful when testing.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
ccd705d 
* upstream/main: (22 commits)
  [skip ci] Updated translations via Crowdin
  Webhook for Wiki changes (go-gitea#20219)
  test: use `T.TempDir` to create temporary test directory (go-gitea#21043)
  Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (go-gitea#20902)
  Fix 500 on time tracking in timeline API (go-gitea#21052)
  Add more checks in migration code (go-gitea#21011)
  Fill the specified ref in webhook test payload (go-gitea#20961)
  [skip ci] Updated licenses and gitignores
  Add go licenses to licenses.txt (go-gitea#21034)
  Added docs for agit-setup (go-gitea#21027)
  Add another index for Action table on postgres (go-gitea#21033)
  Delete unreferenced packages when deleting a package version (go-gitea#20977)
  Improve arc-green code theme (go-gitea#21039)
  Add down key check has tribute container (go-gitea#21016)
  Do not add links to Posters or Assignees with ID < 0 (go-gitea#20577)
  [skip ci] Updated translations via Crowdin
  Show language name on hover (go-gitea#20923)
  fix: PackageMetadataVersion deps (go-gitea#21017)
  Fix the quick-submit for pending review comment (go-gitea#20992)
  Kd/ci playwright go test (go-gitea#20123)
  ...
vanhoang1107 added a commit to vanhoang1107/gitea that referenced this pull request Oct 31, 2022
@vanhoang1107
Merge remote-tracking branch 'src/release/v1.17' into release/v1.17
d7bf1a9 
* src/release/v1.17: (26 commits)
  Fix reaction of issues (go-gitea#21185) (go-gitea#21196)
  Fix CSV diff for added/deleted files (go-gitea#21189) (go-gitea#21193)
  Fix pagination limit parameter problem (go-gitea#21111)
  Add MD5 back to template helper functions to avoid breaking (go-gitea#21102)
  Add changelog for v1.17.2 (go-gitea#21089)
  Fix sub folder in repository missing add file dropdown (go-gitea#21069) (go-gitea#21083)
  Fix hard-coded timeout and error panic in API archive download endpoint (go-gitea#20925) (go-gitea#21051)
  Fix delete user missed some comments (go-gitea#21067) (go-gitea#21068)
  Delete unreferenced packages when deleting a package version (go-gitea#20977) (go-gitea#21060)
  Redirect if user does not exist on admin pages (go-gitea#20981) (go-gitea#21059)
  Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (go-gitea#20902) (go-gitea#21058)
  Fix 500 on time in timeline API (go-gitea#21052) (go-gitea#21057)
  Fill the specified ref in webhook test payload (go-gitea#20961) (go-gitea#21055)
  Add another index for Action table on postgres (go-gitea#21033) (go-gitea#21054)
  fix broken insecureskipverify handling in rediss connection uris (go-gitea#20967) (go-gitea#21053)
  Add more checks in migration code (go-gitea#21011) (go-gitea#21050)
  Add Dev, Peer and Optional dependencies to npm PackageMetadataVersion (go-gitea#21017) (go-gitea#21044)
  Improve arc-green code theme (go-gitea#21039) (go-gitea#21042)
  Add down key check has tribute container (go-gitea#21016) (go-gitea#21038)
  Do not add links to Posters or Assignees with ID < 0 (go-gitea#20577) (go-gitea#21037)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

9 participants

@wolfogre @codecov-commenter @zeripath @lunny @silverwind @wxiaoguang @techknowlogick @lafriks @GiteaBot