Skip to content

Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (#20902) #21058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 1 commit into from
Sep 4, 2022
Merged

Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (#20902) #21058

techknowlogick merged 1 commit into from
Sep 4, 2022

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 4, 2022

Backport #20902

When setting.Git.DisablePartialClone is set to false then the web server will add filter support to web http. It does this by using-c command arguments but this will not work on gitea serv as the upload-pack and receive-pack commands do not support this.

Instead we move these options into the .gitconfig instead.

Fix #20400

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Set uploadpack.allowFilter etc on gitea serv to enable partial clones…
77d9ac7 
… with ssh (go-gitea#20902)

Backport go-gitea#20902

When setting.Git.DisablePartialClone is set to false then the web server will add filter support to web http. It does this by using`-c` command arguments but this will not work on gitea serv as the upload-pack and receive-pack commands do not support this.

Instead we move these options into the .gitconfig instead.

Fix go-gitea#20400

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.17.2 milestone Sep 4, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2022
@techknowlogick techknowlogick merged commit 0db6add into go-gitea:release/v1.17 Sep 4, 2022
@zeripath zeripath deleted the backport-20902-v1.17 branch September 4, 2022 16:21
@Shuenhoy
Copy link

Shuenhoy commented Sep 8, 2022

I can still not use the clone filter with SSH on my instance after upgrading to 1.17.2.
The built-in SSH server is used on my instance. Is this related?

@zeripath
Copy link
Contributor Author

zeripath commented Sep 8, 2022

It really would have been helpful if you could have tested the proposed PR and stated that it didn't solve your issue BEFORE it sat there for two weeks.

@Shuenhoy
Copy link

Shuenhoy commented Sep 8, 2022

It really would have been helpful if you could have tested the proposed PR and stated that it didn't solve your issue BEFORE it sat there for two weeks.

Sorry for that. I was not aware that I could be more helpful by trying the branch of a PR and responding to the community earlier. Thank you for letting me learn this.

vanhoang1107 added a commit to vanhoang1107/gitea that referenced this pull request Oct 31, 2022
@vanhoang1107
Merge remote-tracking branch 'src/release/v1.17' into release/v1.17
d7bf1a9 
* src/release/v1.17: (26 commits)
  Fix reaction of issues (go-gitea#21185) (go-gitea#21196)
  Fix CSV diff for added/deleted files (go-gitea#21189) (go-gitea#21193)
  Fix pagination limit parameter problem (go-gitea#21111)
  Add MD5 back to template helper functions to avoid breaking (go-gitea#21102)
  Add changelog for v1.17.2 (go-gitea#21089)
  Fix sub folder in repository missing add file dropdown (go-gitea#21069) (go-gitea#21083)
  Fix hard-coded timeout and error panic in API archive download endpoint (go-gitea#20925) (go-gitea#21051)
  Fix delete user missed some comments (go-gitea#21067) (go-gitea#21068)
  Delete unreferenced packages when deleting a package version (go-gitea#20977) (go-gitea#21060)
  Redirect if user does not exist on admin pages (go-gitea#20981) (go-gitea#21059)
  Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (go-gitea#20902) (go-gitea#21058)
  Fix 500 on time in timeline API (go-gitea#21052) (go-gitea#21057)
  Fill the specified ref in webhook test payload (go-gitea#20961) (go-gitea#21055)
  Add another index for Action table on postgres (go-gitea#21033) (go-gitea#21054)
  fix broken insecureskipverify handling in rediss connection uris (go-gitea#20967) (go-gitea#21053)
  Add more checks in migration code (go-gitea#21011) (go-gitea#21050)
  Add Dev, Peer and Optional dependencies to npm PackageMetadataVersion (go-gitea#21017) (go-gitea#21044)
  Improve arc-green code theme (go-gitea#21039) (go-gitea#21042)
  Add down key check has tribute container (go-gitea#21016) (go-gitea#21038)
  Do not add links to Posters or Assignees with ID < 0 (go-gitea#20577) (go-gitea#21037)
  ...
@FerdinandStr
Copy link

FerdinandStr commented Nov 7, 2022

Hi,
we encountered the same problem as @Shuenhoy even after updating to 1.17.3
If I try to clone with ssh i get "warning: filtering not recognized by server, ignoring" but over https it works just fine.
Gitea is running as binary install on a redhat 7.5 with the existing ssh client (i think).

I hope this is not the wrong spot to post this message, if I can help in any other way please tell me :)

@panicking
Copy link

panicking commented Nov 13, 2022

@Shuenhoy I have the same problem. Using ubuntu 22.04 LTS and gitea 1.17.3

@lunny
Copy link
Member

lunny commented Nov 13, 2022

Please fire a new issue.

@zeripath
Copy link
Contributor Author

zeripath commented Nov 13, 2022 •
edited
Loading

Is there an easy way to replicate this issue? The stated replicator:

git clone --filter=tree:0 [email protected]:olblak/updatecli-mirror.git tree

works fine now and it works on docker-rootless and docker.

zeripath added a commit to zeripath/gitea that referenced this pull request Nov 13, 2022
@zeripath
Fix enabling partial clones on 1.17
0c9418e 
When backporting go-gitea#20902 in go-gitea#21058 there was a slight misbackport. It was missed that we needed
to remove the global command option before setting the settings.

Fix go-gitea#21805

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Nov 13, 2022
Merged
lunny pushed a commit that referenced this pull request Nov 14, 2022
@zeripath
Fix enabling partial clones on 1.17 (#21809)
65b5c8e 
When backporting #20902 in #21058 there was a slight misbackport. It was
missed that we needed to remove the global command option before setting
the settings.

Fix #21805

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.17.2

Development

Successfully merging this pull request may close these issues.

8 participants

@zeripath @Shuenhoy @FerdinandStr @panicking @lunny @delvh @techknowlogick @GiteaBot